Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1161463006: Always post buffering state updates since they may change sink state. (Closed)

Created:
5 years, 6 months ago by DaleCurtis
Modified:
5 years, 6 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
http://chromium.googlesource.com/chromium/src.git@underflow
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always post buffering state updates since they may change sink state. The lock must never be held when OnTimeStateChanged() is calling into the VideoRendererSink or we can deadlock the compositor thread. With video-only playback occurs a buffering state change for underflow would immediately invoke OnTimeStateChanged(false) which would try to stop the VideoRendererSink under lock. BUG=496466 TEST=video only playback doesn't deadlock. Committed: https://crrev.com/9d8a53f3bf01aed28abbd1f9a713a25362c0d158 Cr-Commit-Position: refs/heads/master@{#332772}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M media/renderers/video_renderer_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
DaleCurtis
No test since it's across component boundaries and we can't DCHECK() that a lock _is ...
5 years, 6 months ago (2015-06-04 00:53:21 UTC) #2
xhwang
lgtm
5 years, 6 months ago (2015-06-04 00:59:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161463006/1
5 years, 6 months ago (2015-06-04 01:01:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-04 03:01:45 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9d8a53f3bf01aed28abbd1f9a713a25362c0d158 Cr-Commit-Position: refs/heads/master@{#332772}
5 years, 6 months ago (2015-06-04 03:03:41 UTC) #7
Yuta Kitamura
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1159573005/ by yutak@chromium.org. ...
5 years, 6 months ago (2015-06-04 09:41:39 UTC) #8
Yuta Kitamura
5 years, 6 months ago (2015-06-04 10:45:44 UTC) #9
Message was sent while issue was closed.
On 2015/06/04 09:41:39, Yuta Kitamura wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1159573005/ by mailto:yutak@chromium.org.
> 
> The reason for reverting is: Speculative revert for Blink layout tests crashes
> on Nexus 4:
>
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Ne...
> (SEGV on CrGpuMain thread is observed)
> 
> Sorry if my guess is not correct; there wasn't
> a clear signal to identify the culprit..

Sorry for the hassle, it turned out the your patch was
innocent, and I'm landing a revert of the revert.

Powered by Google App Engine
This is Rietveld 408576698