Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1161463004: Move URL Loader creation to a separate factory object. (Closed)

Created:
5 years, 6 months ago by Ben Goodger (Google)
Modified:
5 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move URL Loader creation to a separate factory object. R=jam@chromium.org BUG= Committed: https://crrev.com/239b38e3915724f76334f529dae573636d141932 Cr-Commit-Position: refs/heads/master@{#333126}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -40 lines) Patch
M components/html_viewer/blink_platform_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M components/html_viewer/html_viewer.cc View 1 2 4 chunks +7 lines, -2 lines 0 comments Download
M components/html_viewer/web_url_loader_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/web_url_loader_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/mojo_services.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/network/network_service_delegate.h View 2 chunks +8 lines, -2 lines 0 comments Download
M mojo/services/network/network_service_delegate.cc View 3 chunks +14 lines, -1 line 0 comments Download
M mojo/services/network/network_service_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/network/network_service_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M mojo/services/network/public/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/network_service.mojom View 1 chunk +0 lines, -3 lines 0 comments Download
A + mojo/services/network/public/interfaces/url_loader_factory.mojom View 1 1 chunk +4 lines, -2 lines 0 comments Download
A mojo/services/network/url_loader_factory_impl.h View 1 1 chunk +38 lines, -0 lines 0 comments Download
A mojo/services/network/url_loader_factory_impl.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download
M mojo/shell/application_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/application_manager.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M mojo/shell/network_fetcher.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/shell/network_fetcher.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Ben Goodger (Google)
5 years, 6 months ago (2015-06-03 23:28:45 UTC) #1
jam
lgtm https://codereview.chromium.org/1161463004/diff/1/mojo/services/network/url_loader_factory_impl.cc File mojo/services/network/url_loader_factory_impl.cc (right): https://codereview.chromium.org/1161463004/diff/1/mojo/services/network/url_loader_factory_impl.cc#newcode14 mojo/services/network/url_loader_factory_impl.cc:14: #include "mojo/services/network/web_socket_impl.h" nit: don't need all these headers. ...
5 years, 6 months ago (2015-06-04 16:12:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161463004/20001
5 years, 6 months ago (2015-06-05 18:15:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/32142) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-06-05 18:19:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161463004/40001
5 years, 6 months ago (2015-06-05 18:27:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_android/builds/17586)
5 years, 6 months ago (2015-06-05 18:55:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161463004/80001
5 years, 6 months ago (2015-06-05 19:52:23 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 6 months ago (2015-06-05 20:51:48 UTC) #16
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:52:40 UTC) #17
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/239b38e3915724f76334f529dae573636d141932
Cr-Commit-Position: refs/heads/master@{#333126}

Powered by Google App Engine
This is Rietveld 408576698