Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1161433006: Make the DOMStringMap deleter return type void (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Make the DOMStringMap deleter return type void This doesn't change the generated code. BUG=462920 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196602

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M Source/core/dom/DOMStringMap.idl View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
philipj_slow
PTAL
5 years, 6 months ago (2015-06-05 18:37:42 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161433006/1
5 years, 6 months ago (2015-06-05 18:38:14 UTC) #4
Jens Widell
LGTM
5 years, 6 months ago (2015-06-05 18:39:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161433006/1
5 years, 6 months ago (2015-06-05 18:40:02 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 20:24:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196602

Powered by Google App Engine
This is Rietveld 408576698