Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1161433004: Enable element-role-mapping-focusable.html in LayoutTests (Closed)

Created:
5 years, 7 months ago by je_julie(Not used)
Modified:
5 years, 7 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, je_julie, nektarios, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable element-role-mapping-focusable.html in LayoutTests This patch enables element-role-mapping-focusable.html and updates the role for input element with time attribute. BUG=480861 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195988

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/accessibility/element-role-mapping-focusable.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/accessibility/element-role-mapping-focusable-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
je_julie(Not used)
Hi Dominic, This patch enables the TC disabled on https://src.chromium.org/viewvc/blink?view=rev&revision=195622. I added NOTRY=true after check ...
5 years, 7 months ago (2015-05-27 16:15:22 UTC) #2
dmazzoni
lgtm
5 years, 7 months ago (2015-05-27 16:16:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161433004/1
5 years, 7 months ago (2015-05-27 16:17:23 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 16:28:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195988

Powered by Google App Engine
This is Rietveld 408576698