Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8260)

Unified Diff: chromeos/network/network_state_handler_observer.h

Issue 11614035: Improve NetworkStateHandler API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address feedback, state -> connection state Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_state_handler_observer.h
diff --git a/chromeos/network/network_state_handler_observer.h b/chromeos/network/network_state_handler_observer.h
index 07a4a7723413ce86fef66d5b5394b819f8656e53..0f097876eee4e656f82f6e2c7038fc2c7f2946ae 100644
--- a/chromeos/network/network_state_handler_observer.h
+++ b/chromeos/network/network_state_handler_observer.h
@@ -34,17 +34,17 @@ class CHROMEOS_EXPORT NetworkStateHandlerObserver {
// of devices, so they are not passed in the method.
virtual void DeviceListChanged();
- // The active network changed. |network| will be NULL if there is no longer
- // an active network.
- virtual void ActiveNetworkChanged(const NetworkState* network);
+ // The default network changed (includes VPNs) or its connection state
+ // changed. |network| will be NULL if there is no longer a default network.
+ virtual void DefaultNetworkChanged(const NetworkState* network);
- // The state of the active network changed.
- virtual void ActiveNetworkStateChanged(const NetworkState* network);
+ // The connection state of |network| changed.
+ virtual void NetworkStateChanged(const NetworkState* network);
- // One or more network service properties changed. Note: for the active
- // network, this will be called in *addition* to ActiveNetworkStateChanged()
- // if the state property changed.
- virtual void NetworkServiceChanged(const NetworkState* network);
+ // One or more network service properties changed. Note: this will get
pneubeck (no reviews) 2012/12/19 19:40:06 I would still add a reference to |network| ... pro
stevenjb 2012/12/19 21:36:50 Done.
+ // called in *addition* to NetworkStateChanged() when the connection state
+ // property changes. Use this to track properties like wifi strength.
+ virtual void NetworkPropertyChanged(const NetworkState* network);
private:
DISALLOW_COPY_AND_ASSIGN(NetworkStateHandlerObserver);

Powered by Google App Engine
This is Rietveld 408576698