ash/system/chromeos/network/network_icon.cc - Issue 11614035: Improve NetworkStateHandler API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/chromeos/network/network_icon.cc

Issue 11614035: Improve NetworkStateHandler API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address feedback, state -> connection state Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/system/chromeos/network/network_icon.cc

diff --git a/ash/system/chromeos/network/network_icon.cc b/ash/system/chromeos/network/network_icon.cc

index 247007a001e557b0605f1219692d36f4806989ef..9974721781fec156060399684cafd11560cf52e1 100644

--- a/ash/system/chromeos/network/network_icon.cc

+++ b/ash/system/chromeos/network/network_icon.cc

@@ -482,8 +482,8 @@ void NetworkIconImpl::Update(const NetworkState* network) {

bool dirty = image_.isNull();

// If the network state has changed, the icon needs updating.

- if (state_ != network->state()) {

- state_ = network->state();

+ if (state_ != network->connection_state()) {

+ state_ = network->connection_state();

dirty = true;

}