Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Side by Side Diff: chromeos/network/network_state.h

Issue 11614035: Improve NetworkStateHandler API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Separate out OnDefaultNetworkChanged and move kMatchType* to NetworkStateHandler Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMEOS_NETWORK_NETWORK_STATE_H_ 5 #ifndef CHROMEOS_NETWORK_NETWORK_STATE_H_
6 #define CHROMEOS_NETWORK_NETWORK_STATE_H_ 6 #define CHROMEOS_NETWORK_NETWORK_STATE_H_
7 7
8 #include "chromeos/network/managed_state.h" 8 #include "chromeos/network/managed_state.h"
9 9
10 namespace chromeos { 10 namespace chromeos {
(...skipping 10 matching lines...) Expand all
21 21
22 // ManagedState overrides 22 // ManagedState overrides
23 virtual bool PropertyChanged(const std::string& key, 23 virtual bool PropertyChanged(const std::string& key,
24 const base::Value& value) OVERRIDE; 24 const base::Value& value) OVERRIDE;
25 25
26 // Accessors 26 // Accessors
27 const std::string& security() const { return security_; } 27 const std::string& security() const { return security_; }
28 const std::string& technology() const { return technology_; } 28 const std::string& technology() const { return technology_; }
29 const std::string& ip_address() const { return ip_address_; } 29 const std::string& ip_address() const { return ip_address_; }
30 const std::string& device_path() const { return device_path_; } 30 const std::string& device_path() const { return device_path_; }
31 const std::string& state() const { return state_; } 31 const std::string& connection_state() const { return connection_state_; }
32 const std::string& error() const { return error_; } 32 const std::string& error() const { return error_; }
33 const std::string& activation_state() const { return activation_state_; } 33 const std::string& activation_state() const { return activation_state_; }
34 const std::string& roaming() const { return roaming_; } 34 const std::string& roaming() const { return roaming_; }
35 int signal_strength() const { return signal_strength_; } 35 int signal_strength() const { return signal_strength_; }
36 36
37 bool IsConnectedState() const; 37 bool IsConnectedState() const;
38 bool IsConnectingState() const; 38 bool IsConnectingState() const;
39 39
40 // Helpers (used e.g. when a state is cached) 40 // Helpers (used e.g. when a state is cached)
41 static bool StateIsConnected(const std::string& state); 41 static bool StateIsConnected(const std::string& connection_state);
42 static bool StateIsConnecting(const std::string& state); 42 static bool StateIsConnecting(const std::string& connection_state);
43 43
44 private: 44 private:
45 friend class NetworkStateHandler; 45 friend class NetworkStateHandler;
46 46
47 // Called by NetworkStateHandler when the ip config changes. 47 // Called by NetworkStateHandler when the ip config changes.
48 void set_ip_address(const std::string& ip_address) { 48 void set_ip_address(const std::string& ip_address) {
49 ip_address_ = ip_address; 49 ip_address_ = ip_address;
50 } 50 }
51 51
52 // Common Network Service properties 52 // Common Network Service properties
53 std::string security_; 53 std::string security_;
54 std::string device_path_; 54 std::string device_path_;
55 std::string ip_address_; 55 std::string ip_address_;
56 std::string state_; 56 std::string connection_state_;
57 std::string error_; 57 std::string error_;
58 // Wireless properties 58 // Wireless properties
59 int signal_strength_; 59 int signal_strength_;
60 // Cellular properties 60 // Cellular properties
61 std::string technology_; 61 std::string technology_;
62 std::string activation_state_; 62 std::string activation_state_;
63 std::string roaming_; 63 std::string roaming_;
64 64
65 DISALLOW_COPY_AND_ASSIGN(NetworkState); 65 DISALLOW_COPY_AND_ASSIGN(NetworkState);
66 }; 66 };
67 67
68 } // namespace chromeos 68 } // namespace chromeos
69 69
70 #endif // CHROMEOS_NETWORK_NETWORK_STATE_H_ 70 #endif // CHROMEOS_NETWORK_NETWORK_STATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698