Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: sdk/lib/io/http_impl.dart

Issue 11614028: Revert "Fixes to eventhandler and HTTP" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/socket.cc ('k') | sdk/lib/io/socket_stream_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http_impl.dart
diff --git a/sdk/lib/io/http_impl.dart b/sdk/lib/io/http_impl.dart
index bdae934dbb196280cb8a61c751aaa3538a85c189..6a610a88d9bdf91d68ef0630c56d0b5e1cf25368 100644
--- a/sdk/lib/io/http_impl.dart
+++ b/sdk/lib/io/http_impl.dart
@@ -34,7 +34,7 @@ class _CloseQueue {
connection._state |= _HttpConnectionBase.CLOSING;
_q.add(connection);
- // If the output stream is not closed for writing, close it now and
+ // If output stream is not closed for writing close it now and
// wait for callback when closed.
if (!connection._isWriteClosed) {
connection._socket.outputStream.close();
@@ -940,7 +940,6 @@ class _HttpConnection extends _HttpConnectionBase {
_request = null;
_response = null;
if (close) {
- _httpParser.cancel();
_server._closeQueue.add(this);
} else {
_state = _HttpConnectionBase.IDLE;
@@ -952,7 +951,7 @@ class _HttpConnection extends _HttpConnectionBase {
// not care to read the request body) this is send.
assert(!_isRequestDone);
_writeBufferedResponse();
- _httpParser.cancel();
+ _close();
_server._closeQueue.add(this);
}
}
« no previous file with comments | « runtime/bin/socket.cc ('k') | sdk/lib/io/socket_stream_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698