Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 1161393003: Media player: Add shortcut keys (Ctrl+Shift+I/J/C/B) to media players for debug. (Closed)

Created:
5 years, 6 months ago by fukino
Modified:
5 years, 6 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media player: Add shortcut keys (Ctrl+Shift+I/J/C/B) to media players for debug. BUG=494903 TEST=manually Committed: https://crrev.com/8c339d29f10c89ab76d46599db870ae4e3132f9d Cr-Commit-Position: refs/heads/master@{#332535}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -1 line) Patch
M ui/file_manager/audio_player/js/audio_player.js View 2 chunks +25 lines, -0 lines 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 1 chunk +15 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
Could you take a look? Thanks!
5 years, 6 months ago (2015-06-02 08:33:45 UTC) #2
yoshiki
lgtm
5 years, 6 months ago (2015-06-02 09:34:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161393003/1
5 years, 6 months ago (2015-06-03 01:31:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 03:20:29 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 03:21:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c339d29f10c89ab76d46599db870ae4e3132f9d
Cr-Commit-Position: refs/heads/master@{#332535}

Powered by Google App Engine
This is Rietveld 408576698