Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1161363002: Fix Map/Set creation via the API with nosnap build (Closed)

Created:
5 years, 6 months ago by adamk
Modified:
5 years, 6 months ago
CC:
arv (Not doing code reviews), v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Map/Set creation via the API with nosnap build The Map and Set maps get overwritten when collection.js executes, so in a nosnap build we have to wait until it runs before we grab the maps. To facilitate that, store the functions in the native context as well. Committed: https://crrev.com/dd4cd1fe90c7d6a445706950663cf38d79af9403 Cr-Commit-Position: refs/heads/master@{#28743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/bootstrapper.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/contexts.h View 2 chunks +4 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
adamk
5 years, 6 months ago (2015-06-01 21:27:08 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161363002/1
5 years, 6 months ago (2015-06-01 21:29:47 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-01 21:30:09 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-01 23:04:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161363002/1
5 years, 6 months ago (2015-06-01 23:13:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 23:16:33 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 23:16:49 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd4cd1fe90c7d6a445706950663cf38d79af9403
Cr-Commit-Position: refs/heads/master@{#28743}

Powered by Google App Engine
This is Rietveld 408576698