Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(156)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1161323007: Use nullptr instead of 0 in xml and xmlhttprequest. (Closed)

Created:
4 years, 10 months ago by prashant.hiremath
Modified:
4 years, 10 months ago
Reviewers:
sof
CC:
blink-reviews, tyoshino+watch_chromium.org, blink-reviews-style_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Use nullptr instead of 0 in xml and xmlhttprequest. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196667

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated as per review comment & modified in other files which assigned "0" to ptr. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -37 lines) Patch
M Source/core/xml/DocumentXSLT.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathFunctions.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/xml/XPathNodeSet.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/XPathParser.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathResult.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/xml/XSLImportRule.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XSLStyleSheetLibxslt.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/xml/XSLTProcessorLibxslt.cpp View 1 8 chunks +11 lines, -11 lines 0 comments Download
M Source/core/xml/XSLTUnicodeSort.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
prashant.hiremath
Please review.
4 years, 10 months ago (2015-06-08 04:32:40 UTC) #2
sof
https://codereview.chromium.org/1161323007/diff/1/Source/core/xml/XPathFunctions.cpp File Source/core/xml/XPathFunctions.cpp (right): https://codereview.chromium.org/1161323007/diff/1/Source/core/xml/XPathFunctions.cpp#newcode599 Source/core/xml/XPathFunctions.cpp:599: const Attribute* languageAttribute = 0; s/0/nullptr/ https://codereview.chromium.org/1161323007/diff/1/Source/core/xml/XPathFunctions.cpp#newcode739 Source/core/xml/XPathFunctions.cpp:739: FunctionRec* ...
4 years, 10 months ago (2015-06-08 07:09:06 UTC) #3
prashant.hiremath
PTAL.
4 years, 10 months ago (2015-06-08 08:43:18 UTC) #4
sof
lgtm, thanks!
4 years, 10 months ago (2015-06-08 10:53:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161323007/20001
4 years, 10 months ago (2015-06-08 11:03:19 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-08 12:08:51 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196667

Powered by Google App Engine
This is Rietveld 408576698