Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1161323004: Export Point, Size, Rect, Color, Paint, Path, BoxDecoration, Border, BorderSide, EdgeDims, and Flex… (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Export Point, Size, Rect, Color, Paint, Path, BoxDecoration, Border, BorderSide, EdgeDims, and FlexDirection from fn2.dart That way most of our libraries don't have to use sky.Foo all over the place, and we can reduce the number of imports in most Dart components. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6101af757ac8c48bdd62f9af90f92789536367ea

Patch Set 1 #

Patch Set 2 : without analyser changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+371 lines, -385 lines) Patch
M sky/sdk/lib/framework/app.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/components2/drawer.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M sky/sdk/lib/framework/components2/fixed_height_scrollable.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sky/sdk/lib/framework/components2/icon.dart View 2 chunks +1 line, -3 lines 0 comments Download
M sky/sdk/lib/framework/components2/menu_divider.dart View 2 chunks +1 line, -3 lines 0 comments Download
M sky/sdk/lib/framework/components2/menu_item.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M sky/sdk/lib/framework/components2/radio.dart View 1 2 chunks +3 lines, -5 lines 0 comments Download
M sky/sdk/lib/framework/components2/scaffold.dart View 1 4 chunks +10 lines, -12 lines 0 comments Download
M sky/sdk/lib/framework/components2/tool_bar.dart View 2 chunks +2 lines, -5 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 4 chunks +6 lines, -3 lines 0 comments Download
M sky/sdk/lib/framework/rendering/block.dart View 4 chunks +5 lines, -6 lines 0 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 1 37 chunks +65 lines, -65 lines 0 comments Download
M sky/sdk/lib/framework/rendering/flex.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M sky/sdk/lib/framework/rendering/object.dart View 1 3 chunks +4 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/rendering/paragraph.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M sky/sdk/lib/framework/rendering/stack.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M sky/sdk/lib/framework/theme2/colors.dart View 1 chunk +248 lines, -248 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-05 17:14:16 UTC) #2
Hixie
5 years, 6 months ago (2015-06-05 17:18:54 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
6101af757ac8c48bdd62f9af90f92789536367ea (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698