Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 1161323002: DevTools: implement JavaScriptCallFrame binding based on v8 API (Closed)

Created:
4 years, 11 months ago by yurys
Modified:
4 years, 11 months ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg_samsung, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: implement JavaScriptCallFrame binding based on v8 API This class is going to be moved into a separate component and should not depend on the Blink bindings implementation. BUG=466631 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196422

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Don't create more than one wrapper template per isolate #

Patch Set 4 : Moved V8JavaScriptCallFrame to bindings/core/v8/inspector/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -103 lines) Patch
M Source/bindings/core/v8/V8Debugger.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/core/v8/V8Debugger.cpp View 1 2 3 5 chunks +8 lines, -3 lines 0 comments Download
D Source/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp View 1 chunk +0 lines, -87 lines 0 comments Download
M Source/bindings/core/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
A Source/bindings/core/v8/inspector/V8JavaScriptCallFrame.h View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
A Source/bindings/core/v8/inspector/V8JavaScriptCallFrame.cpp View 1 2 3 1 chunk +251 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/v8.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.h View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
yurys
4 years, 11 months ago (2015-06-01 16:32:32 UTC) #2
yurys
alph
4 years, 11 months ago (2015-06-02 14:53:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161323002/20001
4 years, 11 months ago (2015-06-02 14:54:00 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 11 months ago (2015-06-02 14:54:04 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161323002/20001
4 years, 11 months ago (2015-06-02 14:59:48 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/37049)
4 years, 11 months ago (2015-06-02 15:19:35 UTC) #11
sergeyv
lgtm
4 years, 11 months ago (2015-06-03 10:36:17 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161323002/40001
4 years, 11 months ago (2015-06-03 16:13:24 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/37214)
4 years, 11 months ago (2015-06-03 16:36:54 UTC) #17
yurys
gn builders fail as -Igen/blink goes before -I../../third_party/WebKit/Source on the compiler command line and in ...
4 years, 11 months ago (2015-06-03 17:12:58 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161323002/60001
4 years, 11 months ago (2015-06-03 17:30:20 UTC) #21
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 18:46:46 UTC) #22
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196422

Powered by Google App Engine
This is Rietveld 408576698