Issue 11613017: Focus launcher if spoken feedback is enabled and no other windows visible.

Issue 11613017: Focus launcher if spoken feedback is enabled and no other windows visible. (Closed)

Created:
8 years ago by mtomasz

Modified:
8 years ago

Reviewers:
Zachary Kuznia, sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Focus launcher if spoken feedback is enabled and no other windows visible. This patch automatically focuses launcher if no other windows are available and spoken feedback is enabled. TBR=sky BUG=156772 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173686

Patch Set 1 #

Patch Set 2 : Added two more unit tests. #

Total comments: 2

Patch Set 3 : Added an include. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+257 lines, -7 lines)			Patch
M	ash/ash.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/launcher/launcher.h	View		4 chunks	+13 lines, -1 line	0 comments	Download
M	ash/launcher/launcher.cc	View		5 chunks	+23 lines, -4 lines	0 comments	Download
M	ash/launcher/launcher_unittest.cc	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	ash/wm/activation_controller_delegate.h	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	ash/wm/ash_activation_controller.h	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	ash/wm/ash_activation_controller.cc	View		3 chunks	+37 lines, -0 lines	0 comments	Download
A	ash/wm/ash_activation_controller_unittest.cc	View	1	1 chunk	+158 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Zachary Kuznia

Update the description to note that you're relanding https://codereview.chromium.org/11451002/ https://src.chromium.org/viewvc/chrome?view=rev&revision=173417, and explain what you fixed. ...

8 years ago (2012-12-18 03:54:58 UTC) #2

mtomasz

https://codereview.chromium.org/11613017/diff/10/ash/wm/activation_controller_delegate.h File ash/wm/activation_controller_delegate.h (right): https://codereview.chromium.org/11613017/diff/10/ash/wm/activation_controller_delegate.h#newcode7 ash/wm/activation_controller_delegate.h:7: On 2012/12/18 03:54:58, Zachary Kuznia wrote: > #include "ash/ash_export.h" ...

8 years ago (2012-12-18 03:57:53 UTC) #3

mtomasz

Added sky@ to TBR, since he has already gave an LGTM to this code here: ...

8 years ago (2012-12-18 04:01:21 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/11613017/5001

8 years ago (2012-12-18 06:49:45 UTC) #5

Message was sent while issue was closed.

Change committed as 173686

Expand Messages | Collapse Messages