Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: vm/debugger.cc

Issue 11613009: Changed the API in DartEntry for invoking dart code from C++ to make it more compatible with the re… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« vm/dart_entry.h ('K') | « vm/dart_entry_test.cc ('k') | vm/isolate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/debugger.cc
===================================================================
--- vm/debugger.cc (revision 16285)
+++ vm/debugger.cc (working copy)
@@ -1127,10 +1127,9 @@
bool saved_ignore_flag = ignore_breakpoints_;
ignore_breakpoints_ = true;
if (setjmp(*jump.Set()) == 0) {
- GrowableArray<const Object*> noArguments;
- const Array& noArgumentNames = Array::Handle();
- result = DartEntry::InvokeDynamic(object, getter_func,
- noArguments, noArgumentNames);
+ const Array& args = Array::Handle(Array::New(1));
+ args.SetAt(0, object);
+ result = DartEntry::InvokeDynamic(getter_func, args);
} else {
result = isolate_->object_store()->sticky_error();
}
@@ -1167,9 +1166,8 @@
bool saved_ignore_flag = ignore_breakpoints_;
ignore_breakpoints_ = true;
if (setjmp(*jump.Set()) == 0) {
- GrowableArray<const Object*> noArguments;
- const Array& noArgumentNames = Array::Handle();
- result = DartEntry::InvokeStatic(getter_func, noArguments, noArgumentNames);
+ const Array& args = Array::Handle(Object::empty_array());
+ result = DartEntry::InvokeStatic(getter_func, args);
} else {
result = isolate_->object_store()->sticky_error();
}
« vm/dart_entry.h ('K') | « vm/dart_entry_test.cc ('k') | vm/isolate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698