Changed the API in DartEntry for invoking dart code from C++ to make it more compatible with the re…

vm/dart_entry.h

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_DART_ENTRY_H_
 #define VM_DART_ENTRY_H_
 
 #include "vm/allocation.h"
 #include "vm/growable_array.h"
 
@@ skipping 35 matching lines @@
   static intptr_t name_offset() { return kNameOffset * kWordSize; }
   static intptr_t position_offset() { return kPositionOffset * kWordSize; }
   static intptr_t named_entry_size() { return kNamedEntrySize * kWordSize; }
 
   // Allocate and return an arguments descriptor.  The first
   // (count - optional_arguments_names.Length()) arguments are
   // positional and the remaining ones are named optional arguments.
   static RawArray* New(intptr_t count,
                        const Array& optional_arguments_names);
 
+  // Allocate and return an arguments descriptor that has no optional
+  // arguments. All arguments are positional.
+  static RawArray* New(intptr_t count);
+
  private:
   // Absolute indexes into the array.
   enum {
     kCountIndex,
     kPositionalCountIndex,
     kFirstNamedEntryIndex,
   };
 
   // Relative indexes into each named argument entry.
   enum {
@@ skipping 13 matching lines @@
 };
 
 
 // DartEntry abstracts functionality needed to resolve dart functions
 // and invoke them from C++.
 class DartEntry : public AllStatic {
  public:
   // On success, returns a RawInstance.  On failure, a RawError.
   typedef RawObject* (*invokestub)(uword entry_point,
                                    const Array& arguments_descriptor,
-                                   const Object** arguments,
+                                   const Array& arguments,
                                    const Context& context);
 
   // Invokes the specified instance function on the receiver.
   // On success, returns a RawInstance.  On failure, a RawError.
+  // This is used when there are no named arguments in the call.
+  static RawObject* InvokeDynamic(const Function& function,
+                                  const Array& arguments);
+
+  // Invokes the specified instance function on the receiver.
+  // On success, returns a RawInstance.  On failure, a RawError.
   static RawObject* InvokeDynamic(

[regis, 2012/12/18 21:34:46]

Restore indentation as for InvokeDynamic above?

[siva, 2012/12/18 23:14:36]

Forgot these in my last submission, will make these changes in the next CL.

On 2012/12/18 21:34:46, regis wrote:

-      const Instance& receiver,
       const Function& function,
-      const GrowableArray<const Object*>& arguments,
-      const Array& optional_arguments_names);
+      const Array& arguments,
+      const Array& arguments_descriptor);
+
+  // Invoke the specified static function.
+  // On success, returns a RawInstance.  On failure, a RawError.
+  // This is used when there are no named arguments in the call.
+  static RawObject* InvokeStatic(const Function& function,
+                                 const Array& arguments);
 
   // Invoke the specified static function.
   // On success, returns a RawInstance.  On failure, a RawError.
   static RawObject* InvokeStatic(

[regis, 2012/12/18 21:34:46]

Restore indentation as for InvokeStatic above?

[siva, 2012/12/18 23:14:36]

Ditto.

On 2012/12/18 21:34:46, regis wrote:

       const Function& function,
-      const GrowableArray<const Object*>& arguments,
-      const Array& optional_arguments_names);
+      const Array& arguments,
+      const Array& arguments_descriptor);
+
+  // Invoke the specified closure object.
+  // On success, returns a RawInstance.  On failure, a RawError.
+  // This is used when there are no named arguments in the call.
+  static RawObject* InvokeClosure(const Instance& closure,
+                                  const Array& arguments);
 
   // Invoke the specified closure object.
   // On success, returns a RawInstance.  On failure, a RawError.
   static RawObject* InvokeClosure(

[regis, 2012/12/18 21:34:46]

Restore indentation as for InvokeClosure above?

[siva, 2012/12/18 23:14:36]

Ditto.

On 2012/12/18 21:34:46, regis wrote:

       const Instance& closure,
-      const GrowableArray<const Object*>& arguments,
-      const Array& optional_arguments_names);
+      const Array& arguments,
+      const Array& arguments_descriptor);
 };
 
 
 // Utility functions to call from VM into Dart bootstrap libraries.
 // Each may return an exception object.
 class DartLibraryCalls : public AllStatic {
  public:
   // On success, returns a RawInstance.  On failure, a RawError.
   static RawObject* ExceptionCreate(
       const Library& library,
@@ skipping 23 matching lines @@
 
   // Gets the _id field of a SendPort/ReceivePort.
   //
   // Returns the value of _id on success, a RawError on failure.
   static RawObject* PortGetId(const Instance& port);
 };
 
 }  // namespace dart
 
 #endif  // VM_DART_ENTRY_H_