runtime/lib/identical.cc - Issue 11613003: Implement a native identical function in the VM.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/identical.cc

Issue 11613003: Implement a native identical function in the VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Add native 'identical' to VM Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file

	2 // for details. All rights reserved. Use of this source code is governed by a

	3 // BSD-style license that can be found in the LICENSE file.

	4

	5 #include "vm/bootstrap_natives.h"

	6

	7 namespace dart {

	8

	9 DEFINE_NATIVE_ENTRY(Identical_comparison, 2) {

	10 GET_NON_NULL_NATIVE_ARGUMENT(

	11 Instance, a, arguments->NativeArgAt(0));

	12 GET_NON_NULL_NATIVE_ARGUMENT(

	13 Instance, b, arguments->NativeArgAt(1));

	14 // If the objects are both smi's, compare their values.

	15 if (a.IsSmi() && b.IsSmi()) {

	16 return Bool::Get(a.Equals(b));
	srdjan 2012/12/17 19:42:47 YOu need to do the same for Doubles, Mints and Big YOu need to do the same for Doubles, Mints and Bigints Max Heinritz (Google) 2012/12/17 21:15:23 Done. Show quoted text On 2012/12/17 19:42:47, srdjan wrote: > YOu need to do the same for Doubles, Mints and Bigints Done.
	17 }

	18 // If the objects are not smi's, then compare their references.

	19 return Bool::Get(a.raw() == b.raw());

	20 }

	21

	22

	23 } // namespace dart

OLD	NEW