Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: include/gpu/GrXferProcessor.h

Issue 1161273005: Update XPF invariant info to not account for conflation (Closed) Base URL: https://skia.googlesource.com/skia.git@upload_reenablebea
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/gpu/GrPaint.h ('k') | include/gpu/effects/GrCoverageSetOpXP.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/gpu/GrXferProcessor.h
diff --git a/include/gpu/GrXferProcessor.h b/include/gpu/GrXferProcessor.h
index 812a9b32ab353ec8f6172bf701a77042e2cc02bc..d39163c6df00989f9da0df5731cdb74875c8e6b9 100644
--- a/include/gpu/GrXferProcessor.h
+++ b/include/gpu/GrXferProcessor.h
@@ -363,19 +363,23 @@ public:
*/
virtual bool supportsRGBCoverage(GrColor knownColor, uint32_t knownColorFlags) const = 0;
- struct InvariantOutput {
- bool fWillBlendWithDst;
- GrColor fBlendedColor;
- uint32_t fBlendedColorFlags;
+ /**
+ * Known color information after blending, but before accounting for any coverage.
+ */
+ struct InvariantBlendedColor {
+ bool fWillBlendWithDst;
+ GrColor fKnownColor;
+ GrColorComponentFlags fKnownColorFlags;
};
/**
- * This function returns known information about the output of the xfer processor produced by
- * this xp factory. The invariant color information returned by this function refers to the
- * final color produced after all blending.
+ * Returns information about the output color, produced by XPs from this factory, that will be
+ * known after blending. Note that we can conflate coverage and color, so the actual values
+ * written to pixels with partial coverage may not always seem consistent with the invariant
+ * information returned by this function.
*/
- virtual void getInvariantOutput(const GrProcOptInfo& colorPOI, const GrProcOptInfo& coveragePOI,
- InvariantOutput*) const = 0;
+ virtual void getInvariantBlendedColor(const GrProcOptInfo& colorPOI,
+ InvariantBlendedColor*) const = 0;
bool willNeedDstTexture(const GrCaps& caps, const GrProcOptInfo& colorPOI,
const GrProcOptInfo& coveragePOI) const;
« no previous file with comments | « include/gpu/GrPaint.h ('k') | include/gpu/effects/GrCoverageSetOpXP.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698