Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1161273004: Add a Color class to dart:sky. (Closed)

Created:
5 years, 6 months ago by Matt Perry
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -7 lines) Patch
M sky/engine/bindings/scripts/dart_types.py View 3 chunks +5 lines, -1 line 0 comments Download
M sky/engine/core/core.gni View 2 chunks +3 lines, -0 lines 0 comments Download
A sky/engine/core/painting/CanvasColor.h View 1 chunk +31 lines, -0 lines 0 comments Download
A sky/engine/core/painting/CanvasColor.cpp View 1 chunk +45 lines, -0 lines 0 comments Download
A sky/engine/core/painting/Color.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Paint.h View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Paint.idl View 1 chunk +2 lines, -1 line 0 comments Download
M sky/engine/core/script/dom_dart_state.h View 2 chunks +2 lines, -0 lines 0 comments Download
M sky/engine/core/script/dom_dart_state.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M sky/examples/raw/painting.sky View 3 chunks +6 lines, -5 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Matt Perry
5 years, 6 months ago (2015-06-01 20:30:30 UTC) #2
eseidel
lgtm https://codereview.chromium.org/1161273004/diff/1/sky/examples/raw/painting.sky File sky/examples/raw/painting.sky (right): https://codereview.chromium.org/1161273004/diff/1/sky/examples/raw/painting.sky#newcode26 sky/examples/raw/painting.sky:26: print("color: ${paint.color.value}"); Intentional?
5 years, 6 months ago (2015-06-01 20:34:23 UTC) #3
Matt Perry
https://codereview.chromium.org/1161273004/diff/1/sky/examples/raw/painting.sky File sky/examples/raw/painting.sky (right): https://codereview.chromium.org/1161273004/diff/1/sky/examples/raw/painting.sky#newcode26 sky/examples/raw/painting.sky:26: print("color: ${paint.color.value}"); On 2015/06/01 20:34:23, eseidel wrote: > Intentional? ...
5 years, 6 months ago (2015-06-01 20:38:50 UTC) #4
Matt Perry
5 years, 6 months ago (2015-06-01 20:48:52 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a413c8319fe9a46dc131f6efe275d014c9cb7eb9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698