compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java - Issue 11612027: Issue 7469. Report error if type appears in for extends and implements clauses

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java

Issue 11612027: Issue 7469. Report error if type appears in for extends and implements clauses (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Remove commented status line Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/ResolverErrorCode.java ('k') | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java b/compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java

index 0aef7bcb7de08c3ef0d123a617271b5931a35a67..6e1b911ecd316aa2baa72c34f45e7262a520e3c7 100644

--- a/compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java

+++ b/compiler/java/com/google/dart/compiler/resolver/SupertypeResolver.java

@@ -4,6 +4,7 @@

package com.google.dart.compiler.resolver;

+import com.google.common.base.Objects;

import com.google.common.collect.ImmutableSet;

import com.google.common.collect.Sets;

import com.google.dart.compiler.DartCompilerContext;

@@ -111,6 +112,10 @@ public class SupertypeResolver {

topLevelContext.onError(intNode, ResolverErrorCode.DUPLICATE_IMPLEMENTS_TYPE);

continue;

}

+ if (Objects.equal(intType, supertype)) {

+ topLevelContext.onError(intNode, ResolverErrorCode.SUPER_CLASS_IN_IMPLEMENTS);

+ continue;

+ }

seenImplement.add(intType);

}

// OK, add