Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1161183003: Revert "Chromium changes to statically link ffmpeg." (Closed)

Created:
5 years, 6 months ago by chcunningham
Modified:
5 years, 6 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, hguihot+watch_chromium.org, yzshen+watch_chromium.org, stevenjb+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, grt+watch_chromium.org, lcwu+watch_chromium.org, chromoting-reviews_chromium.org, jam, ben+mojo_chromium.org, abarth-chromium, eme-reviews_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, hubbe+watch_chromium.org, mlamouri+watch-content_chromium.org, imcheng+watch_chromium.org, jasonroberts+watch_google.com, feature-media-reviews_chromium.org, oshima+watch_chromium.org, kalyank, gunsch+watch_chromium.org, Michael Moss, darin (slow to review), hclam+watch_chromium.org, wfh+watch_chromium.org, avayvod+watch_chromium.org, asvitkine+watch_chromium.org, Aaron Boodman, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Chromium changes to statically link ffmpeg." Reverting because of component test failures around isolate expectations. This change may not actually be directly responsible, but I'm out of time to investigate for the day. Will re-land it soon. BUG=496975 TBR=enne@chromium.org, gunsch@chromium.org, jochen@chromium.org, isherman@chromium.org, thomasvl@chromium.org, phajdan@chromium.org, grt@chromium.org, mmoss@chromium.org, sergeyu@chromium.org, sky@chromium.org, dalecurtis@chromium.org This reverts commit bfef6d6ba82b172ac0e48c80d9ccf1a1ca0ea5c5. NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/a31b9ad7e78a1e6174fd218a78b0909079e0afd5 Cr-Commit-Position: refs/heads/master@{#332994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+475 lines, -68 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash_unittests.isolate View 2 chunks +2 lines, -0 lines 0 comments Download
M cc/cc_unittests.isolate View 3 chunks +3 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome.isolate View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_installer.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/linux/common/installer.include View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/plugin/chrome_content_plugin_client.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromeos/autotest/files/client/deps/chrome_test/setup_test_links.sh View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/chromeos/autotest/files/client/deps/pyauto_dep/setup_test_links.sh View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/chromeos/FILES.cfg View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/tools/build/linux/FILES.cfg View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/tools/build/mac/TESTS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/mac/dump_product_syms View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/unit_tests.isolate View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M chromecast/media/cma/test/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/components_unittests.isolate View 4 chunks +4 lines, -0 lines 0 comments Download
M components/html_viewer/media_factory.cc View 1 chunk +5 lines, -1 line 0 comments Download
M content/app/content_main_runner.cc View 1 chunk +6 lines, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_browsertests.isolate View 4 chunks +4 lines, -0 lines 0 comments Download
M content/content_gl_tests.isolate View 1 chunk +15 lines, -0 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M content/content_unittests.isolate View 4 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +8 lines, -1 line 0 comments Download
M content/test/content_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +13 lines, -3 lines 0 comments Download
M media/audio_unittests.isolate View 1 chunk +22 lines, -0 lines 0 comments Download
M media/base/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M media/base/media.h View 1 chunk +26 lines, -3 lines 0 comments Download
M media/base/media.cc View 1 chunk +43 lines, -17 lines 0 comments Download
A media/base/media_posix.cc View 1 chunk +66 lines, -0 lines 0 comments Download
A media/base/media_stub.cc View 1 chunk +19 lines, -0 lines 0 comments Download
A media/base/media_win.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M media/base/run_all_perftests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/run_all_unittests.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/cast_unittests.isolate View 3 chunks +21 lines, -0 lines 0 comments Download
M media/cast/sender/audio_encoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/audio_sender_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/sender/h264_vt_encoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/sender.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M media/cast/test/simulator.cc View 1 chunk +4 lines, -1 line 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M media/ffmpeg/ffmpeg_common_unittest.cc View 3 chunks +12 lines, -4 lines 0 comments Download
M media/filters/ffmpeg_glue.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M media/media.gyp View 4 chunks +5 lines, -1 line 0 comments Download
M media/media_nacl.gyp View 2 chunks +1 line, -3 lines 0 comments Download
M media/media_unittests.isolate View 1 chunk +22 lines, -0 lines 0 comments Download
M media/mojo/services/renderer_config_default.cc View 1 chunk +6 lines, -1 line 0 comments Download
M media/test/pipeline_integration_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/base/run_all_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/chromoting/chromoting_integration_tests.isolate View 3 chunks +3 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
chcunningham
5 years, 6 months ago (2015-06-05 02:05:21 UTC) #2
M-A Ruel
lgtm
5 years, 6 months ago (2015-06-05 02:16:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161183003/1
5 years, 6 months ago (2015-06-05 02:20:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161183003/1
5 years, 6 months ago (2015-06-05 02:24:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-05 02:26:45 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 02:27:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a31b9ad7e78a1e6174fd218a78b0909079e0afd5
Cr-Commit-Position: refs/heads/master@{#332994}

Powered by Google App Engine
This is Rietveld 408576698