Chromecast: split DummyMediaTaskRunner class into its own file.

Chromecast: split DummyMediaTaskRunner class into its own file.

- also rename class to SimpleMediaTaskRunner

BUG= internal b/18865809

Committed: https://crrev.com/3e8d72a32a541dd323bd3d1bac6c84ca166c49c1
Cr-Commit-Position: refs/heads/master@{#333163}

[erickung1, 2015-06-05 00:49:09]

erickung@chromium.org changed reviewers:
+ gunsch@chromium.org, lcwu@chromium.org, servolk@chromium.org

[gunsch, 2015-06-05 18:09:20]

https://codereview.chromium.org/1161163003/diff/1/chromecast/media/cma/base/d...
File chromecast/media/cma/base/dummy_media_task_runner.cc (right):

https://codereview.chromium.org/1161163003/diff/1/chromecast/media/cma/base/d...
chromecast/media/cma/base/dummy_media_task_runner.cc:13: const
scoped_refptr<base::SingleThreadTaskRunner>& task_runner)
Dummy sounds like it doesn't do anything. This does, it's just a very simple
implementation of doing so. How about SimpleMediaTaskRunner?

[erickung1, 2015-06-05 19:28:19]

https://codereview.chromium.org/1161163003/diff/1/chromecast/media/cma/base/d...
File chromecast/media/cma/base/dummy_media_task_runner.cc (right):

https://codereview.chromium.org/1161163003/diff/1/chromecast/media/cma/base/d...
chromecast/media/cma/base/dummy_media_task_runner.cc:13: const
scoped_refptr<base::SingleThreadTaskRunner>& task_runner)
On 2015/06/05 18:09:20, gunsch wrote:
> Dummy sounds like it doesn't do anything. This does, it's just a very simple
> implementation of doing so. How about SimpleMediaTaskRunner?

Done.

[gunsch, 2015-06-05 20:15:30]

lgtm % style and documentation nits

https://codereview.chromium.org/1161163003/diff/20001/chromecast/media/cma/ba...
File chromecast/media/cma/base/simple_media_task_runner.cc (right):

https://codereview.chromium.org/1161163003/diff/20001/chromecast/media/cma/ba...
chromecast/media/cma/base/simple_media_task_runner.cc:14: :
task_runner_(task_runner) {
style nit: indentation

probably run "git cl format" on this CL for good measure

https://codereview.chromium.org/1161163003/diff/20001/chromecast/media/cma/ba...
File chromecast/media/cma/base/simple_media_task_runner.h (right):

https://codereview.chromium.org/1161163003/diff/20001/chromecast/media/cma/ba...
chromecast/media/cma/base/simple_media_task_runner.h:17: class
SimpleMediaTaskRunner : public MediaTaskRunner {
Maybe document that this simply calls PostTask immediately and that timestamps
are ignored

https://codereview.chromium.org/1161163003/diff/20001/chromecast/media/cma/ba...
chromecast/media/cma/base/simple_media_task_runner.h:31:
scoped_refptr<base::SingleThreadTaskRunner> const task_runner_;
include base/memory/ref_counted.h

https://codereview.chromium.org/1161163003/diff/20001/chromecast/media/cma/ba...
chromecast/media/cma/base/simple_media_task_runner.h:33:
DISALLOW_COPY_AND_ASSIGN(SimpleMediaTaskRunner);
include base/macros.h

[erickung1, 2015-06-05 22:22:16]

https://codereview.chromium.org/1161163003/diff/20001/chromecast/media/cma/ba...
File chromecast/media/cma/base/simple_media_task_runner.cc (right):

https://codereview.chromium.org/1161163003/diff/20001/chromecast/media/cma/ba...
chromecast/media/cma/base/simple_media_task_runner.cc:14: :
task_runner_(task_runner) {
On 2015/06/05 20:15:30, gunsch wrote:
> style nit: indentation
> 
> probably run "git cl format" on this CL for good measure

Done.

https://codereview.chromium.org/1161163003/diff/20001/chromecast/media/cma/ba...
File chromecast/media/cma/base/simple_media_task_runner.h (right):

https://codereview.chromium.org/1161163003/diff/20001/chromecast/media/cma/ba...
chromecast/media/cma/base/simple_media_task_runner.h:17: class
SimpleMediaTaskRunner : public MediaTaskRunner {
On 2015/06/05 20:15:30, gunsch wrote:
> Maybe document that this simply calls PostTask immediately and that timestamps
> are ignored

Done.

https://codereview.chromium.org/1161163003/diff/20001/chromecast/media/cma/ba...
chromecast/media/cma/base/simple_media_task_runner.h:31:
scoped_refptr<base::SingleThreadTaskRunner> const task_runner_;
On 2015/06/05 20:15:30, gunsch wrote:
> include base/memory/ref_counted.h

Done.

https://codereview.chromium.org/1161163003/diff/20001/chromecast/media/cma/ba...
chromecast/media/cma/base/simple_media_task_runner.h:33:
DISALLOW_COPY_AND_ASSIGN(SimpleMediaTaskRunner);
On 2015/06/05 20:15:30, gunsch wrote:
> include base/macros.h

Done.

[erickung1, 2015-06-05 22:22:23]

The CQ bit was checked by erickung@chromium.org

[erickung1, 2015-06-05 22:22:23]

The patchset sent to the CQ was uploaded after l-g-t-m from gunsch@chromium.org
Link to the patchset: https://codereview.chromium.org/1161163003/#ps40001
(title: "Reformat the code to meet style guide")

[commit-bot: I haz the power, 2015-06-05 22:23:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161163003/40001

[commit-bot: I haz the power, 2015-06-05 22:43:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-05 22:44:33]

Patchset 3 (id:??) landed as
https://crrev.com/3e8d72a32a541dd323bd3d1bac6c84ca166c49c1
Cr-Commit-Position: refs/heads/master@{#333163}