chrome/browser/push_messaging/push_messaging_browsertest.cc - Issue 1161153003: Convert the WebRtcTestBase to use infobar and bubble autoresponders

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_browsertest.cc

Issue 1161153003: Convert the WebRtcTestBase to use infobar and bubble autoresponders (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix MANUAL test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/platform_notification_service_browsertest.cc ('k') | chrome/test/data/webrtc/getusermedia.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_browsertest.cc

diff --git a/chrome/browser/push_messaging/push_messaging_browsertest.cc b/chrome/browser/push_messaging/push_messaging_browsertest.cc

index a9acc332a6556cd6b09235315b9669915ab57a5a..0cd1a74eda5a83814646feaaee026aff34de5d3a 100644

--- a/chrome/browser/push_messaging/push_messaging_browsertest.cc

+++ b/chrome/browser/push_messaging/push_messaging_browsertest.cc

@@ -243,7 +243,8 @@ void PushMessagingBrowserTest::RequestAndAcceptPermission() {

PermissionBubbleManager::ACCEPT_ALL);

EXPECT_TRUE(RunScript("requestNotificationPermission();", &script_result));

} else {

- InfoBarResponder infobar_accept_responder(GetInfoBarService(), true);

+ InfoBarResponder infobar_accept_responder(GetInfoBarService(),

+ InfoBarResponder::ACCEPT);

EXPECT_TRUE(RunScript("requestNotificationPermission();", &script_result));

}

EXPECT_EQ("permission status - granted", script_result);

@@ -257,7 +258,8 @@ void PushMessagingBrowserTest::RequestAndDenyPermission() {

PermissionBubbleManager::DENY_ALL);

EXPECT_TRUE(RunScript("requestNotificationPermission();", &script_result));

} else {

- InfoBarResponder infobar_deny_responder(GetInfoBarService(), false);

+ InfoBarResponder infobar_deny_responder(GetInfoBarService(),

+ InfoBarResponder::DENY);

EXPECT_TRUE(RunScript("requestNotificationPermission();", &script_result));

}

EXPECT_EQ("permission status - denied", script_result);

@@ -319,7 +321,8 @@ IN_PROC_BROWSER_TEST_P(PushMessagingBrowserTest,

PermissionBubbleManager::ACCEPT_ALL);

ASSERT_TRUE(RunScript("subscribePush()", &script_result));

} else {

- InfoBarResponder infobar_accept_responder(GetInfoBarService(), true);

+ InfoBarResponder infobar_accept_responder(GetInfoBarService(),

+ InfoBarResponder::ACCEPT);

ASSERT_TRUE(RunScript("subscribePush()", &script_result));

}

EXPECT_EQ(GetEndpointForSubscriptionId("1-0"), script_result);