Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1161143002: /infra directory (Closed)

Created:
5 years, 6 months ago by nodir
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

/infra-config directory Added /infra with chrome-infra specific files. /infra/project-config/cr-buildbucket.cfg defines v8 buckets on cr-buildbucket.appspot.com R=tandrii@chromium.org, machenbach@chromium.org, sergiyb@chromium.org BUG= Committed: https://crrev.com/db18b77836fc02d443ac42b025fc6e5c49ecf55d Cr-Commit-Position: refs/heads/master@{#28736}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
A infra/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A infra/README.md View 1 1 chunk +1 line, -0 lines 0 comments Download
A infra/project-config/README.md View 1 1 chunk +1 line, -0 lines 0 comments Download
A infra/project-config/cr-buildbucket.cfg View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (9 generated)
nodir
PTAL
5 years, 6 months ago (2015-05-29 18:30:14 UTC) #3
Sergiy Byelozyorov
lgtm was this location agreed upon with Michael? https://codereview.chromium.org/1161143002/diff/40001/infra/README.md File infra/README.md (right): https://codereview.chromium.org/1161143002/diff/40001/infra/README.md#newcode1 infra/README.md:1: This ...
5 years, 6 months ago (2015-05-29 19:09:28 UTC) #4
nodir
https://codereview.chromium.org/1161143002/diff/40001/infra/README.md File infra/README.md (right): https://codereview.chromium.org/1161143002/diff/40001/infra/README.md#newcode1 infra/README.md:1: This directory contains chrome-infra-specific files. On 2015/05/29 19:09:27, Sergiy ...
5 years, 6 months ago (2015-05-29 19:16:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161143002/60001
5 years, 6 months ago (2015-05-29 19:17:05 UTC) #8
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-05-29 19:17:08 UTC) #10
nodir
On 2015/05/29 19:17:08, commit-bot: I haz the power wrote: > No LGTM from a valid ...
5 years, 6 months ago (2015-05-29 19:18:41 UTC) #11
nodir
Sergiy, since you are in MUC where v8 team is (AFAIU), can you find another ...
5 years, 6 months ago (2015-05-29 22:38:11 UTC) #12
tandrii_google
On 2015/05/29 22:38:11, nodir wrote: > Sergiy, since you are in MUC where v8 team ...
5 years, 6 months ago (2015-05-31 16:03:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161143002/60001
5 years, 6 months ago (2015-05-31 16:39:06 UTC) #15
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-05-31 16:39:08 UTC) #17
Sergiy Byelozyorov
On 2015/05/31 16:39:08, commit-bot: I haz the power wrote: > No LGTM from a valid ...
5 years, 6 months ago (2015-06-01 13:25:16 UTC) #18
Sergiy Byelozyorov
Added Igor who can rubber stump this change.
5 years, 6 months ago (2015-06-01 13:27:04 UTC) #20
Igor Sheludko
lgtm
5 years, 6 months ago (2015-06-01 13:28:02 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161143002/60001
5 years, 6 months ago (2015-06-01 15:32:32 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 6 months ago (2015-06-01 16:19:43 UTC) #24
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 16:20:04 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/db18b77836fc02d443ac42b025fc6e5c49ecf55d
Cr-Commit-Position: refs/heads/master@{#28736}

Powered by Google App Engine
This is Rietveld 408576698