Delete code corresponding to old UMA prefs.

Delete code corresponding to old UMA prefs.

Sufficient time has passed that the vast majority
of users have migrated.

BUG=357704
Committed: https://crrev.com/f2e0aaae2dcf8421d6f3117aeecd4decf353a946
Cr-Commit-Position: refs/heads/master@{#332268}

[Alexei Svitkine (slow), 2015-05-29 18:40:14]

asvitkine@chromium.org changed reviewers:
+ jwd@chromium.org

[jwd, 2015-05-29 18:46:22]

https://codereview.chromium.org/1161133004/diff/1/components/metrics/metrics_...
File components/metrics/metrics_state_manager.cc (right):

https://codereview.chromium.org/1161133004/diff/1/components/metrics/metrics_...
components/metrics/metrics_state_manager.cc:127: if
(local_state_->GetString(prefs::kMetricsOldClientID).empty()) {
What about this migration code, and obsoleting the related histograms?

[Alexei Svitkine (slow), 2015-05-29 18:59:17]

https://codereview.chromium.org/1161133004/diff/1/components/metrics/metrics_...
File components/metrics/metrics_state_manager.cc (right):

https://codereview.chromium.org/1161133004/diff/1/components/metrics/metrics_...
components/metrics/metrics_state_manager.cc:127: if
(local_state_->GetString(prefs::kMetricsOldClientID).empty()) {
On 2015/05/29 18:46:22, Jesse Doherty wrote:
> What about this migration code, and obsoleting the related histograms?

Err, you're right. Done.

[jwd, 2015-05-29 19:01:55]

lgtm

[Alexei Svitkine (slow), 2015-05-29 19:02:25]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2015-05-29 19:04:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161133004/40001

[commit-bot: I haz the power, 2015-05-29 19:25:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-29 19:25:44]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Alexei Svitkine (slow), 2015-05-29 19:46:46]

asvitkine@chromium.org changed reviewers:
+ gfhuang@chromium.org

[Alexei Svitkine (slow), 2015-05-29 19:46:47]

Oops, my last CL accidentally killed the code to set the enabled data, which a
test caught. :) Restored.

Also, there's some Chromecast code that was checking the old pref. Updated that
as well, and +gfhuang to review from the Chromecast side.

(If it's undesirable to make this change to Chromecast code, we can move the
pref into Chromecast prefs instead and keep the code.)

[gfhuang, 2015-05-29 19:54:03]

https://codereview.chromium.org/1161133004/diff/60001/chromecast/browser/metr...
File chromecast/browser/metrics/cast_metrics_service_client.cc (left):

https://codereview.chromium.org/1161133004/diff/60001/chromecast/browser/metr...
chromecast/browser/metrics/cast_metrics_service_client.cc:75: if
(!pref_service_->GetString(::metrics::prefs::kMetricsOldClientID)
can you keep this logic and just make a local 
"const char kMetricsOldClientID[] = "user_experience_metrics.client_id" in the
top of this file.

We still don't know how many pre-v1.2 devices in the fields.

[Alexei Svitkine (slow), 2015-05-29 20:12:53]

Patchset #5 (id:80001) has been deleted

[Alexei Svitkine (slow), 2015-05-29 20:13:23]

https://codereview.chromium.org/1161133004/diff/60001/chromecast/browser/metr...
File chromecast/browser/metrics/cast_metrics_service_client.cc (left):

https://codereview.chromium.org/1161133004/diff/60001/chromecast/browser/metr...
chromecast/browser/metrics/cast_metrics_service_client.cc:75: if
(!pref_service_->GetString(::metrics::prefs::kMetricsOldClientID)
On 2015/05/29 19:54:03, gfhuang wrote:
> can you keep this logic and just make a local 
> "const char kMetricsOldClientID[] = "user_experience_metrics.client_id" in the
> top of this file.
> 
> We still don't know how many pre-v1.2 devices in the fields.

Done.

[gunsch, 2015-05-29 20:14:29]

gunsch@chromium.org changed reviewers:
+ gunsch@chromium.org

[gunsch, 2015-05-29 20:14:30]

https://codereview.chromium.org/1161133004/diff/100001/chromecast/browser/met...
File chromecast/browser/metrics/cast_metrics_service_client.cc (right):

https://codereview.chromium.org/1161133004/diff/100001/chromecast/browser/met...
chromecast/browser/metrics/cast_metrics_service_client.cc:18: #include
"components/metrics/metrics_pref_names.h"
I think you can remove this include now, too

[Alexei Svitkine (slow), 2015-05-29 20:31:49]

https://codereview.chromium.org/1161133004/diff/100001/chromecast/browser/met...
File chromecast/browser/metrics/cast_metrics_service_client.cc (right):

https://codereview.chromium.org/1161133004/diff/100001/chromecast/browser/met...
chromecast/browser/metrics/cast_metrics_service_client.cc:18: #include
"components/metrics/metrics_pref_names.h"
On 2015/05/29 20:14:30, gunsch wrote:
> I think you can remove this include now, too

Done.

[Alexei Svitkine (slow), 2015-06-01 19:04:08]

gfhuang/gunsch: friendly ping

[gunsch, 2015-06-01 19:09:41]

Thanks for ping, thought I'd stamped. lgtm

[Alexei Svitkine (slow), 2015-06-01 19:59:36]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-06-01 19:59:37]

The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/1161133004/#ps120001
(title: "Moar comments.")

[commit-bot: I haz the power, 2015-06-01 20:02:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161133004/120001

[commit-bot: I haz the power, 2015-06-01 21:23:27]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2015-06-01 21:24:14]

Patchset 6 (id:??) landed as
https://crrev.com/f2e0aaae2dcf8421d6f3117aeecd4decf353a946
Cr-Commit-Position: refs/heads/master@{#332268}