Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1161133002: Fix sky_server.py on Mac and make sky_server executable if it's not already (Closed)

Created:
5 years, 6 months ago by jackson
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix sky_server.py on Mac and make sky_server executable if it's not already R=eseidel@chromium.org, eseidel Committed: https://chromium.googlesource.com/external/mojo/+/513d6acc4a272e951e467fa492b56f513fd1e941

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M sky/tools/skypy/skyserver.py View 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jackson
5 years, 6 months ago (2015-05-29 17:45:59 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-05-29 17:46:11 UTC) #2
eseidel
5 years, 6 months ago (2015-05-29 17:47:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
513d6acc4a272e951e467fa492b56f513fd1e941 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698