Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(31)

Issue 1161093004: Allow compositing of hidden layers (Closed)

Created:
4 years, 11 months ago by Ian Vollick
Modified:
4 years, 11 months ago
Reviewers:
dstockwell
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Allow compositing of hidden layers Hidden layers may require compositing in order for animation machinery to be plumbed to the compositor. This was broken in r170249. With this CL, we allow hidden layers to be composited, but only if they house a compositor-driven animation. BUG=444852 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196451

Patch Set 1 #

Patch Set 2 : only allow compositing of hidden layers when they're animating. #

Patch Set 3 : added test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -4 lines) Patch
A LayoutTests/compositing/animation/hidden-composited.html View 1 2 1 chunk +56 lines, -0 lines 0 comments Download
A + LayoutTests/compositing/animation/hidden-composited-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/compositing/CompositingReasonFinder.h View 1 2 chunks +1 line, -1 line 0 comments Download
M Source/core/layout/compositing/DeprecatedPaintLayerCompositor.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Ian Vollick
4 years, 11 months ago (2015-06-03 18:34:04 UTC) #2
dstockwell
lgtm
4 years, 11 months ago (2015-06-04 01:05:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161093004/40001
4 years, 11 months ago (2015-06-04 01:06:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64912)
4 years, 11 months ago (2015-06-04 01:43:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161093004/40001
4 years, 11 months ago (2015-06-04 02:33:08 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 03:55:26 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196451

Powered by Google App Engine
This is Rietveld 408576698