Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Unified Diff: src/objects.cc

Issue 1161073002: [es6] Make sure we call add property when adding a new property (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/es6/regress/regress-cr493566.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 180eb63536c1f35bf5d07189478a81c55951d281..fad3d2e0264420b272408a91f9b71bbade6df13a 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -3333,7 +3333,8 @@ MaybeHandle<Object> Object::SetSuperProperty(LookupIterator* it,
MaybeHandle<Object> result = SetPropertyInternal(
&own_lookup, value, language_mode, store_mode, &found);
if (found) return result;
- return SetDataProperty(&own_lookup, value);
+ return AddDataProperty(&own_lookup, value, NONE, language_mode,
arv (Not doing code reviews) 2015/06/01 14:17:58 AddDataProperty has a DCHECK that the receiver is
caitp (gmail) 2015/06/01 14:36:38 In the current implementation, found can be false
Toon Verwaest 2015/06/01 14:37:03 Not if the receiver is the proxy, as is the case h
Toon Verwaest 2015/06/01 14:41:29 I think you'd want to make this switch nested in a
+ store_mode);
}
}
« no previous file with comments | « no previous file | test/mjsunit/es6/regress/regress-cr493566.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698