Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1161063005: Make FixedHeightScrollable understand heights (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make FixedHeightScrollable understand heights This CL makes FixedHeightScrollable able to measure heights. In the DOM-based version, FixedHeightScrollable forced a synchronous layout in a microtask in order to measure the size of itself and its children. In the DOM-less version, we now require the subclass to tell us the item height and we measure our own height using a layout callback. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/c35710c6b7a6452eb0551fe5f3c4015e0b26e2a2

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -29 lines) Patch
M sky/sdk/lib/framework/components2/fixed_height_scrollable.dart View 1 chunk +24 lines, -29 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 chunk +16 lines, -0 lines 2 comments Download
M sky/sdk/lib/framework/rendering/box.dart View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-04 20:27:45 UTC) #1
Hixie
lgtm https://codereview.chromium.org/1161063005/diff/1/sky/sdk/lib/framework/fn2.dart File sky/sdk/lib/framework/fn2.dart (right): https://codereview.chromium.org/1161063005/diff/1/sky/sdk/lib/framework/fn2.dart#newcode437 sky/sdk/lib/framework/fn2.dart:437: } Should probably drop the callback when the ...
5 years, 6 months ago (2015-06-04 20:35:50 UTC) #2
abarth-chromium
https://codereview.chromium.org/1161063005/diff/1/sky/sdk/lib/framework/fn2.dart File sky/sdk/lib/framework/fn2.dart (right): https://codereview.chromium.org/1161063005/diff/1/sky/sdk/lib/framework/fn2.dart#newcode437 sky/sdk/lib/framework/fn2.dart:437: } Done.
5 years, 6 months ago (2015-06-04 20:41:25 UTC) #3
abarth-chromium
5 years, 6 months ago (2015-06-04 20:42:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c35710c6b7a6452eb0551fe5f3c4015e0b26e2a2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698