Move the SeccompSupportDetector to be in-process.

Move the SeccompSupportDetector to be in-process.

Some of this work was previously done in the utility process. Since processes
are expensive on Android, and doing so hasn't helped defend against detection
issues, this is a simpler solution.

BUG=490948, 468455
R=leecam@chromium.org,thestig@chromium.org
TBR=enne@chromium.org

Committed: https://crrev.com/65d313504b845412543f2addafec1e3f18a0c433
Cr-Commit-Position: refs/heads/master@{#333372}

[Lei Zhang, 2015-06-05 19:00:28]

lgtm

https://codereview.chromium.org/1161053004/diff/1/chrome/browser/android/secc...
File chrome/browser/android/seccomp_support_detector.cc (right):

https://codereview.chromium.org/1161053004/diff/1/chrome/browser/android/secc...
chrome/browser/android/seccomp_support_detector.cc:26: DETECTION_FAILED,  // The
process crashed during detection.
DETECTION_FAILED_OBSOLETE?

https://codereview.chromium.org/1161053004/diff/1/chrome/browser/android/secc...
chrome/browser/android/seccomp_support_detector.cc:75: prctl_supported = false;
bool prctl_supported

[Robert Sesek, 2015-06-05 19:21:33]

Patchset #2 (id:20001) has been deleted

[Robert Sesek, 2015-06-08 19:06:08]

Patchset #2 (id:40001) has been deleted

[Robert Sesek, 2015-06-08 21:16:25]

rsesek@chromium.org changed reviewers:
+ jln@chromium.org

[Robert Sesek, 2015-06-08 21:16:26]

Thanks, +jln for //sandbox/linux DEPS

https://codereview.chromium.org/1161053004/diff/1/chrome/browser/android/secc...
File chrome/browser/android/seccomp_support_detector.cc (right):

https://codereview.chromium.org/1161053004/diff/1/chrome/browser/android/secc...
chrome/browser/android/seccomp_support_detector.cc:26: DETECTION_FAILED,  // The
process crashed during detection.
On 2015/06/05 19:00:28, Lei Zhang wrote:
> DETECTION_FAILED_OBSOLETE?

Done.

https://codereview.chromium.org/1161053004/diff/1/chrome/browser/android/secc...
chrome/browser/android/seccomp_support_detector.cc:75: prctl_supported = false;
On 2015/06/05 19:00:28, Lei Zhang wrote:
> bool prctl_supported

Good catch, thanks!

[mdempsky, 2015-06-08 22:16:28]

mdempsky@chromium.org changed reviewers:
+ mdempsky@chromium.org

[mdempsky, 2015-06-08 22:16:29]

RSLGTM for sandbox/linux/OWNERS

[mdempsky, 2015-06-08 22:17:22]

LGTM

[Robert Sesek, 2015-06-08 22:17:57]

rsesek@chromium.org changed reviewers:
+ enne@chromium.org

[Robert Sesek, 2015-06-08 22:18:36]

TBRing enne@ for DEPS change, because I added a trailing , (which is matching
the OWNERS check rule).

[Robert Sesek, 2015-06-08 22:18:41]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2015-06-08 22:18:41]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1161053004/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2015-06-08 22:19:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1161053004/60001

[enne (OOO), 2015-06-08 22:19:49]

On 2015/06/08 at 22:18:36, rsesek wrote:
> TBRing enne@ for DEPS change, because I added a trailing , (which is matching
the OWNERS check rule).

Commas always lgtm.  ;)

[jln (very slow on Chromium), 2015-06-08 22:49:25]

lgtm

[commit-bot: I haz the power, 2015-06-08 22:53:52]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-06-08 22:54:35]

Patchset 2 (id:??) landed as
https://crrev.com/65d313504b845412543f2addafec1e3f18a0c433
Cr-Commit-Position: refs/heads/master@{#333372}