Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: components/autofill/core/common/password_form_fill_data.cc

Issue 1161023008: Suggest to fill password change forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added tests, addressed comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/password_form_fill_data.cc
diff --git a/components/autofill/core/common/password_form_fill_data.cc b/components/autofill/core/common/password_form_fill_data.cc
index 714e8f57b5df5b6f12b975d1619dfcfade99458a..dbd20362563a1c1051969ba43e7181c860719a3b 100644
--- a/components/autofill/core/common/password_form_fill_data.cc
+++ b/components/autofill/core/common/password_form_fill_data.cc
@@ -55,6 +55,9 @@ void InitPasswordFormFillData(
result->username_field = username_field;
result->password_field = password_field;
result->wait_for_username = wait_for_username_before_autofill;
+ result->is_password_change_form =
+ form_on_page.layout != PasswordForm::Layout::LAYOUT_LOGIN_AND_SIGNUP &&
+ !form_on_page.new_password_element.empty();
Garrett Casto 2015/06/09 23:56:22 It would be really nice if we only had to compute
dvadym 2015/06/10 14:22:03 I've added method IsChangePasswordForm in Password
result->preferred_realm = preferred_match->original_signon_realm;

Powered by Google App Engine
This is Rietveld 408576698