Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: components/autofill/core/common/password_form.h

Issue 1161023008: Suggest to fill password change forms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tiny fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/password_form.h
diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h
index 96633264b01e32a407cdf3e9d150ee763faad6f0..d0e9d7cdcaa9fcccac5e61d5409a19c1b1c38828 100644
--- a/components/autofill/core/common/password_form.h
+++ b/components/autofill/core/common/password_form.h
@@ -271,6 +271,10 @@ struct PasswordForm {
// Returns true if this match was found using public suffix matching.
bool IsPublicSuffixMatch() const;
+ // Return true if we consider this form to be a change password form.
+ // We use only client heuristics for this, so probably we are wrong.
Garrett Casto 2015/06/12 22:22:16 I wouldn't say "probably we are wrong" here. I wou
dvadym 2015/06/15 09:34:59 I changed text to "We use only client heuristics,
+ bool IsPossibleChangePasswordForm() const;
+
// Equality operators for testing.
bool operator==(const PasswordForm& form) const;
bool operator!=(const PasswordForm& form) const;

Powered by Google App Engine
This is Rietveld 408576698