Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 1161023006: Adds basic support for images in game example (Closed)

Created:
5 years, 6 months ago by viktorl
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, WRONG ACCOUNT, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Initial version of working game with Box2D, images, nodes and sprites. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/595e5ef3abf08ff479e3c5125bcb6468cc36fa4d

Patch Set 1 #

Total comments: 1

Patch Set 2 : git cl status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -25 lines) Patch
M sky/examples/game/lib/game_world.dart View 1 1 chunk +5 lines, -11 lines 0 comments Download
A sky/examples/game/lib/image_map.dart View 1 1 chunk +38 lines, -0 lines 0 comments Download
M sky/examples/game/lib/sprite_box.dart View 1 3 chunks +36 lines, -10 lines 0 comments Download
M sky/examples/game/lib/sprites.dart View 1 1 chunk +5 lines, -3 lines 0 comments Download
M sky/examples/game/main.dart View 1 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
viktorl
5 years, 6 months ago (2015-06-01 21:44:24 UTC) #2
eseidel
Very cool.
5 years, 6 months ago (2015-06-01 21:45:25 UTC) #3
Cutch
On 2015/06/01 21:45:25, eseidel wrote: > Very cool. Nice!
5 years, 6 months ago (2015-06-01 21:55:16 UTC) #4
abarth-chromium
Neat! https://codereview.chromium.org/1161023006/diff/1/sky/examples/game/lib/sprite_node.dart File sky/examples/game/lib/sprite_node.dart (right): https://codereview.chromium.org/1161023006/diff/1/sky/examples/game/lib/sprite_node.dart#newcode10 sky/examples/game/lib/sprite_node.dart:10: SpriteNode() : super() { The call to super() ...
5 years, 6 months ago (2015-06-01 21:58:55 UTC) #5
abarth-chromium
LGTM
5 years, 6 months ago (2015-06-01 21:59:08 UTC) #7
eseidel
You can land this with "git cl land" and it will automatically close this bug. ...
5 years, 6 months ago (2015-06-02 19:13:15 UTC) #8
viktorl
5 years, 6 months ago (2015-06-02 22:09:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
595e5ef3abf08ff479e3c5125bcb6468cc36fa4d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698