Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1161023003: Wait until rebooting is done if java assert is not set. (Closed)

Created:
5 years, 6 months ago by JungJik
Modified:
5 years, 6 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wait until rebooting is done if java assert is not set. When we turn the device on, java assert flag would have been unset. In this status if we execute test_runner.py, this script will exit with -1 because the device is still rebooting. so we should wait for adb connection until the device is fully rebooted. BUG=None Committed: https://crrev.com/585d2566e78f683f180583ba8e6f3844d44c14c6 Cr-Commit-Position: refs/heads/master@{#332559}

Patch Set 1 #

Total comments: 4

Patch Set 2 : remove lock screen code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/android/pylib/instrumentation/test_runner.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
JungJik
Please take a look this patch.
5 years, 6 months ago (2015-05-29 04:51:45 UTC) #2
jbudorick
https://codereview.chromium.org/1161023003/diff/1/build/android/pylib/instrumentation/test_runner.py File build/android/pylib/instrumentation/test_runner.py (right): https://codereview.chromium.org/1161023003/diff/1/build/android/pylib/instrumentation/test_runner.py#newcode102 build/android/pylib/instrumentation/test_runner.py:102: device_settings.SetLockScreenSettings(self.device) Why would we set the lock screen settings ...
5 years, 6 months ago (2015-05-29 13:06:15 UTC) #3
JungJik
https://codereview.chromium.org/1161023003/diff/1/build/android/pylib/instrumentation/test_runner.py File build/android/pylib/instrumentation/test_runner.py (right): https://codereview.chromium.org/1161023003/diff/1/build/android/pylib/instrumentation/test_runner.py#newcode102 build/android/pylib/instrumentation/test_runner.py:102: device_settings.SetLockScreenSettings(self.device) On 2015/05/29 13:06:15, jbudorick wrote: > Why would ...
5 years, 6 months ago (2015-06-01 14:44:51 UTC) #4
jbudorick
https://codereview.chromium.org/1161023003/diff/1/build/android/pylib/instrumentation/test_runner.py File build/android/pylib/instrumentation/test_runner.py (right): https://codereview.chromium.org/1161023003/diff/1/build/android/pylib/instrumentation/test_runner.py#newcode102 build/android/pylib/instrumentation/test_runner.py:102: device_settings.SetLockScreenSettings(self.device) On 2015/06/01 at 14:44:51, JungJik wrote: > On ...
5 years, 6 months ago (2015-06-01 14:50:56 UTC) #5
JungJik
https://codereview.chromium.org/1161023003/diff/1/build/android/pylib/instrumentation/test_runner.py File build/android/pylib/instrumentation/test_runner.py (right): https://codereview.chromium.org/1161023003/diff/1/build/android/pylib/instrumentation/test_runner.py#newcode102 build/android/pylib/instrumentation/test_runner.py:102: device_settings.SetLockScreenSettings(self.device) On 2015/06/01 14:50:56, jbudorick wrote: > On 2015/06/01 ...
5 years, 6 months ago (2015-06-02 16:09:45 UTC) #6
jbudorick
lgtm
5 years, 6 months ago (2015-06-02 16:50:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1161023003/20001
5 years, 6 months ago (2015-06-03 03:53:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-03 05:36:53 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 05:37:38 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/585d2566e78f683f180583ba8e6f3844d44c14c6
Cr-Commit-Position: refs/heads/master@{#332559}

Powered by Google App Engine
This is Rietveld 408576698