Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: src/compiler/linkage.cc

Issue 1160983004: [turbofan] First step towards sanitizing for-in and making it optimizable. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add some comments. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/js-operator.cc ('k') | src/compiler/opcodes.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stubs.h" 5 #include "src/code-stubs.h"
6 #include "src/compiler.h" 6 #include "src/compiler.h"
7 #include "src/compiler/linkage.h" 7 #include "src/compiler/linkage.h"
8 #include "src/compiler/node.h" 8 #include "src/compiler/node.h"
9 #include "src/compiler/pipeline.h" 9 #include "src/compiler/pipeline.h"
10 #include "src/scopes.h" 10 #include "src/scopes.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 // static 107 // static
108 bool Linkage::NeedsFrameState(Runtime::FunctionId function) { 108 bool Linkage::NeedsFrameState(Runtime::FunctionId function) {
109 // Most runtime functions need a FrameState. A few chosen ones that we know 109 // Most runtime functions need a FrameState. A few chosen ones that we know
110 // not to call into arbitrary JavaScript, not to throw, and not to deoptimize 110 // not to call into arbitrary JavaScript, not to throw, and not to deoptimize
111 // are blacklisted here and can be called without a FrameState. 111 // are blacklisted here and can be called without a FrameState.
112 switch (function) { 112 switch (function) {
113 case Runtime::kAllocateInTargetSpace: 113 case Runtime::kAllocateInTargetSpace:
114 case Runtime::kDefineClassMethod: // TODO(jarin): Is it safe? 114 case Runtime::kDefineClassMethod: // TODO(jarin): Is it safe?
115 case Runtime::kDefineGetterPropertyUnchecked: // TODO(jarin): Is it safe? 115 case Runtime::kDefineGetterPropertyUnchecked: // TODO(jarin): Is it safe?
116 case Runtime::kDefineSetterPropertyUnchecked: // TODO(jarin): Is it safe? 116 case Runtime::kDefineSetterPropertyUnchecked: // TODO(jarin): Is it safe?
117 case Runtime::kForInCacheArrayLength: 117 case Runtime::kForInDone:
118 case Runtime::kForInInit: 118 case Runtime::kForInStep:
119 case Runtime::kForInNext:
120 case Runtime::kNewArguments: 119 case Runtime::kNewArguments:
121 case Runtime::kNewClosure: 120 case Runtime::kNewClosure:
122 case Runtime::kNewFunctionContext: 121 case Runtime::kNewFunctionContext:
123 case Runtime::kNewRestParamSlow: 122 case Runtime::kNewRestParamSlow:
124 case Runtime::kPushBlockContext: 123 case Runtime::kPushBlockContext:
125 case Runtime::kPushCatchContext: 124 case Runtime::kPushCatchContext:
126 case Runtime::kReThrow: 125 case Runtime::kReThrow:
127 case Runtime::kSetProperty: // TODO(jarin): Is it safe? 126 case Runtime::kSetProperty: // TODO(jarin): Is it safe?
128 case Runtime::kStringCompareRT: 127 case Runtime::kStringCompareRT:
129 case Runtime::kStringEquals: 128 case Runtime::kStringEquals:
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 198
200 CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone, 199 CallDescriptor* Linkage::GetSimplifiedCDescriptor(Zone* zone,
201 const MachineSignature* sig) { 200 const MachineSignature* sig) {
202 UNIMPLEMENTED(); 201 UNIMPLEMENTED();
203 return NULL; 202 return NULL;
204 } 203 }
205 #endif // !V8_TURBOFAN_BACKEND 204 #endif // !V8_TURBOFAN_BACKEND
206 } // namespace compiler 205 } // namespace compiler
207 } // namespace internal 206 } // namespace internal
208 } // namespace v8 207 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/js-operator.cc ('k') | src/compiler/opcodes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698