Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1160973008: MIPS64: Fix '[es6] Super call in arrows and eval'. (Closed)

Created:
5 years, 6 months ago by balazs.kilvady
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix '[es6] Super call in arrows and eval'. Port 4b8051a02ae9f765b7d803fc7986301abde36007 Original commit message: This splits the SuperReference AST node into SuperPropertyReference and SuperCallReference. The super call reference node consists of three unresolved vars to this, new.target and this_function. These gets declared when the right function is entered and if it is in use. The variables gets assigned in FullCodeGenerator::Generate. This is a revert of the revert 88b1c9170a0293cbcc8bdaf57fbe12744b48d7e8 BUG=v8:3768 LOG=N Committed: https://crrev.com/614d6a3ba4b79321b08e7b68f1c07133bdbf59a7 Cr-Commit-Position: refs/heads/master@{#28795}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/mips64/full-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
balazs.kilvady
5 years, 6 months ago (2015-06-03 16:58:03 UTC) #2
arv (Not doing code reviews)
LGTM Thanks
5 years, 6 months ago (2015-06-03 17:04:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160973008/1
5 years, 6 months ago (2015-06-03 17:30:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 17:57:24 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 17:57:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/614d6a3ba4b79321b08e7b68f1c07133bdbf59a7
Cr-Commit-Position: refs/heads/master@{#28795}

Powered by Google App Engine
This is Rietveld 408576698