Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: bench/SubsetDivisorBench.h

Issue 1160953002: Subset decoding benchmarks (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Separate subclass for each benchmark Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: bench/SubsetDivisorBench.h
diff --git a/bench/SubsetDivisorBench.h b/bench/SubsetDivisorBench.h
new file mode 100644
index 0000000000000000000000000000000000000000..fe3bb0f61a4335864b71305825c375008528d7be
--- /dev/null
+++ b/bench/SubsetDivisorBench.h
@@ -0,0 +1,47 @@
+/*
+ * Copyright 2015 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#include "Benchmark.h"
+#include "SkImageDecoder.h"
+#include "SkImageInfo.h"
+#include "SkStream.h"
+#include "SkString.h"
+
+/*
+ *
+ * This benchmark is designed to test the performance of subset decoding.
+ * It uses a divisor to decode the entire image in a grid of divisor x divisor blocks.
+ *
+ */
+class SubsetDivisorBench : public Benchmark {
scroggo 2015/06/01 17:25:15 I remember you were concerned about having so many
msarett 2015/06/01 20:37:02 I will move them immediately after the next upload
+public:
+
+ static SubsetDivisorBench* Create(SkString* path,
scroggo 2015/06/01 17:25:14 Why does this take a pointer to a path? Why not a
msarett 2015/06/01 20:37:02 Agreed. There is not a good reason for this to be
+ SkColorType colorType,
+ uint32_t divisor,
+ bool useCodec);
+
+protected:
+ const char* onGetName() override;
+ bool isSuitableFor(Backend backend) override;
+ void onDraw(const int n, SkCanvas* canvas) override;
+
+private:
+
+ SubsetDivisorBench(SkString* stream,
+ SkColorType colorType,
+ uint32_t divisor,
+ bool useCodec);
+
+
+ SkString fName;
scroggo 2015/06/01 17:25:14 style nit: typically we line up the names of membe
msarett 2015/06/01 20:37:02 Done.
+ SkColorType fColorType;
+ const uint32_t fDivisor;
+ const bool fUseCodec;
+ SkAutoTDelete<SkMemoryStream> fStream;
+ typedef Benchmark INHERITED;
+};

Powered by Google App Engine
This is Rietveld 408576698