Document that all-hosts works as an optional permission.

Document that all-hosts works as an optional permission.

BUG=158004
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242133

[Jeffrey Yasskin, 2013-12-19 20:40:21]

Im in ur docs finishin ur bugz

[not at google - send to devlin, 2013-12-19 20:53:13]

lgtm

https://codereview.chromium.org/116093007/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/permissions.json (right):

https://codereview.chromium.org/116093007/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/permissions.json:24: "description": "List of origin
permissions. Anything listed here must be a subset of a host that appears in the
<code>optional_permissions</code> list in the manifest. e.g. if
<code>http://*.example.com/</code> or <code>http://*/</code> appears in
<code>optional_permissions</code>, you can request an origin of
<code>http://help.example.com/</code>. Any path is ignored."
nit: For example not e.g.
not nit: double-check that you don't need the trailing * in the URL pattern.

[Jeffrey Yasskin, 2013-12-19 21:32:49]

https://codereview.chromium.org/116093007/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/permissions.json (right):

https://codereview.chromium.org/116093007/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/permissions.json:24: "description": "List of origin
permissions. Anything listed here must be a subset of a host that appears in the
<code>optional_permissions</code> list in the manifest. e.g. if
<code>http://*.example.com/</code> or <code>http://*/</code> appears in
<code>optional_permissions</code>, you can request an origin of
<code>http://help.example.com/</code>. Any path is ignored."
On 2013/12/19 20:53:13, kalman wrote:
> nit: For example not e.g.

Done.

> not nit: double-check that you don't need the trailing * in the URL pattern.

Checked. The / is required, but anything after it gets replaced with a *. We
actually should require an empty path, since it's an origin, not a URL, but we
can't do that within manifest v2.

[commit-bot: I haz the power, 2013-12-19 21:35:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/116093007/20001

[not at google - send to devlin, 2013-12-19 21:54:54]

(lgtm)

https://codereview.chromium.org/116093007/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/permissions.json (right):

https://codereview.chromium.org/116093007/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/permissions.json:24: "description": "List of origin
permissions. Anything listed here must be a subset of a host that appears in the
<code>optional_permissions</code> list in the manifest. e.g. if
<code>http://*.example.com/</code> or <code>http://*/</code> appears in
<code>optional_permissions</code>, you can request an origin of
<code>http://help.example.com/</code>. Any path is ignored."
On 2013/12/19 21:32:50, Jeffrey Yasskin wrote:
> On 2013/12/19 20:53:13, kalman wrote:
> > nit: For example not e.g.
> 
> Done.
> 
> > not nit: double-check that you don't need the trailing * in the URL pattern.
> 
> Checked. The / is required, but anything after it gets replaced with a *. We
> actually should require an empty path, since it's an origin, not a URL, but we
> can't do that within manifest v2.

The API is badly named, it's not an origin (as you say). More like an origin
pattern, but doesn't accept valid origins.

[commit-bot: I haz the power, 2013-12-19 23:15:02]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-19 23:20:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/116093007/20001

[commit-bot: I haz the power, 2013-12-20 07:27:58]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-12-20 17:28:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/116093007/20001

[commit-bot: I haz the power, 2013-12-20 19:12:31]

Change committed as 242133