Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1160923008: Silence a bunch of annoying bogus dartanalyzer warnings. (Closed)

Created:
5 years, 6 months ago by Hixie
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Silence a bunch of annoying bogus dartanalyzer warnings. - several places where we use a getter knowing that it will return a subclass of its declared type, even asserting that it does, but where the analyzer is worried that the getter might start returning a new value unexpectedly, solved by having a temporary local variable shadow the getter and asserting that it doesn't change value - many many places where we do this with parentData specifically, solved by type-erasing parentData. - a place where a mixin wants to be subclassing another class, and uses its methods, solved by saying that the mixin is abstract but implements the superclass R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0e6b06b7e39a2e80ee98371c7ad165fbd084c893

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M sky/sdk/lib/framework/fn2.dart View 5 chunks +14 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/rendering/object.dart View 5 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-05 16:40:51 UTC) #2
Hixie
5 years, 6 months ago (2015-06-05 16:44:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e6b06b7e39a2e80ee98371c7ad165fbd084c893 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698