cc/DEPS - Issue 11609002: cc: Create a cc::ScrollbarThemePainter and an adapter class in compositor bindings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/DEPS

Issue 11609002: cc: Create a cc::ScrollbarThemePainter and an adapter class in compositor bindings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+media",	2 "+media",

3 "+skia/ext",	3 "+skia/ext",

4 "+third_party/skia/include",	4 "+third_party/skia/include",

5 "+third_party/khronos/GLES2/gl2.h",	5 "+third_party/khronos/GLES2/gl2.h",

6 "+third_party/khronos/GLES2/gl2ext.h",	6 "+third_party/khronos/GLES2/gl2ext.h",

7 "+ui/gfx",	7 "+ui/gfx",

8 "+ui/gl",	8 "+ui/gl",

9 # TODO(danakj): Drop dependencies on WebKit Platform API from cc.	9 # TODO(danakj): Drop dependencies on WebKit Platform API from cc.

10 "+third_party/WebKit/Source/Platform/chromium/public/WebCompositorOutputSurfac e.h",	10 "+third_party/WebKit/Source/Platform/chromium/public/WebCompositorOutputSurfac e.h",

11 "+third_party/WebKit/Source/Platform/chromium/public/WebGraphicsContext3D.h",	11 "+third_party/WebKit/Source/Platform/chromium/public/WebGraphicsContext3D.h",

12 "+third_party/WebKit/Source/Platform/chromium/public/WebGraphicsMemoryAllocati on.h",	12 "+third_party/WebKit/Source/Platform/chromium/public/WebGraphicsMemoryAllocati on.h",

13 "+third_party/WebKit/Source/Platform/chromium/public/WebImage.h",	13 "+third_party/WebKit/Source/Platform/chromium/public/WebImage.h",

	14 "+third_party/WebKit/Source/Platform/chromium/public/WebRect.h",
	enne (OOO) 2012/12/17 21:47:41 Are these still needed after your last change? Are these still needed after your last change? danakj 2012/12/17 21:49:16 yes. webscrollbarthemegeometry still returns a web Show quoted text On 2012/12/17 21:47:41, enne wrote: > Are these still needed after your last change? yes. webscrollbarthemegeometry still returns a webrect, so we need this to do the conversion into a gfx::Rect in scrollbar_layer.cc danakj 2012/12/17 21:49:52 the WebScrollbarThemePainter wasn't needed, but I Show quoted text On 2012/12/17 21:49:16, danakj wrote: > On 2012/12/17 21:47:41, enne wrote: > > Are these still needed after your last change? > > yes. webscrollbarthemegeometry still returns a webrect, so we need this to do > the conversion into a gfx::Rect in scrollbar_layer.cc the WebScrollbarThemePainter wasn't needed, but I already axed that one :) enne (OOO) 2012/12/17 21:52:41 Oh, I see. Show quoted text On 2012/12/17 21:49:52, danakj wrote: > On 2012/12/17 21:49:16, danakj wrote: > > On 2012/12/17 21:47:41, enne wrote: > > > Are these still needed after your last change? > > > > yes. webscrollbarthemegeometry still returns a webrect, so we need this to do > > the conversion into a gfx::Rect in scrollbar_layer.cc > > the WebScrollbarThemePainter wasn't needed, but I already axed that one :) Oh, I see.
	15 "+third_party/WebKit/Source/Platform/chromium/public/WebScrollbar.h",

	16 "+third_party/WebKit/Source/Platform/chromium/public/WebScrollbarThemeGeometry .h",

14 ]	17 ]

OLD	NEW

« no previous file with comments | « no previous file | cc/caching_bitmap_content_layer_updater.cc » ('j') | webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h » ('J')