Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11609002: cc: Create a cc::ScrollbarThemePainter and an adapter class in compositor bindings. (Closed)

Created:
8 years ago by danakj
Modified:
8 years ago
Reviewers:
jamesr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org, backer, piman
Visibility:
Public.

Description

cc: Create a cc::ScrollbarThemePainter and an adapter class in compositor bindings. Instead of having the scrollbar layer talk directly to the WebScrollbarThemePainter, we make an abstract interface in cc/ that it can talk to. In the compositor bindings, we implement this class, and forward the function calls made into it over to the WebKit implementation. No change in behaviour, no new tests. This is a prerequisite for https://codereview.chromium.org/11464041/. BUG=123444 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173687

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Patch Set 6 : #

Total comments: 6

Patch Set 7 : virtual #

Patch Set 8 : notry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+494 lines, -100 lines) Patch
M cc/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/caching_bitmap_content_layer_updater.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M cc/cc_tests.gyp View 2 chunks +4 lines, -0 lines 0 comments Download
M cc/content_layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/content_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_painter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/layer_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M cc/scrollbar_layer.h View 1 2 4 chunks +14 lines, -6 lines 0 comments Download
M cc/scrollbar_layer.cc View 1 7 chunks +48 lines, -47 lines 0 comments Download
M cc/scrollbar_layer_unittest.cc View 5 chunks +7 lines, -33 lines 0 comments Download
A cc/scrollbar_theme_painter.h View 1 chunk +36 lines, -0 lines 0 comments Download
A cc/test/fake_scrollbar_theme_painter.h View 1 2 3 1 chunk +59 lines, -0 lines 0 comments Download
A cc/test/fake_scrollbar_theme_painter.cc View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
A cc/test/fake_web_scrollbar.h View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
A cc/test/fake_web_scrollbar.cc View 1 chunk +69 lines, -0 lines 0 comments Download
M cc/tiled_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/compositor_bindings/compositor_bindings.gyp View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/web_scrollbar_layer_impl.cc View 1 2 3 4 2 chunks +9 lines, -1 line 0 comments Download
A webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h View 1 2 3 4 5 6 1 chunk +55 lines, -0 lines 0 comments Download
A webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.cc View 1 2 3 4 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
danakj
Here's the ScrollbarThemePainter without any behaviour changes. This allows us to unit test scrollbar's update() ...
8 years ago (2012-12-17 18:45:28 UTC) #1
enne (OOO)
This looks way better than the previous approach. Thanks! https://codereview.chromium.org/11609002/diff/9001/webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h File webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h (right): https://codereview.chromium.org/11609002/diff/9001/webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h#newcode10 webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h:10: ...
8 years ago (2012-12-17 20:48:54 UTC) #2
danakj
PTAL https://codereview.chromium.org/11609002/diff/9001/webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h File webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h (right): https://codereview.chromium.org/11609002/diff/9001/webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h#newcode10 webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h:10: #include "third_party/WebKit/Source/Platform/chromium/public/WebScrollbarThemePainter.h" On 2012/12/17 20:48:55, enne wrote: > ...
8 years ago (2012-12-17 21:45:08 UTC) #3
danakj
PTAL
8 years ago (2012-12-17 21:46:03 UTC) #4
enne (OOO)
https://codereview.chromium.org/11609002/diff/11004/cc/DEPS File cc/DEPS (right): https://codereview.chromium.org/11609002/diff/11004/cc/DEPS#newcode14 cc/DEPS:14: "+third_party/WebKit/Source/Platform/chromium/public/WebRect.h", Are these still needed after your last change?
8 years ago (2012-12-17 21:47:41 UTC) #5
danakj
https://codereview.chromium.org/11609002/diff/11004/cc/DEPS File cc/DEPS (right): https://codereview.chromium.org/11609002/diff/11004/cc/DEPS#newcode14 cc/DEPS:14: "+third_party/WebKit/Source/Platform/chromium/public/WebRect.h", On 2012/12/17 21:47:41, enne wrote: > Are these ...
8 years ago (2012-12-17 21:49:16 UTC) #6
danakj
https://codereview.chromium.org/11609002/diff/11004/cc/DEPS File cc/DEPS (right): https://codereview.chromium.org/11609002/diff/11004/cc/DEPS#newcode14 cc/DEPS:14: "+third_party/WebKit/Source/Platform/chromium/public/WebRect.h", On 2012/12/17 21:49:16, danakj wrote: > On 2012/12/17 ...
8 years ago (2012-12-17 21:49:52 UTC) #7
enne (OOO)
lgtm https://codereview.chromium.org/11609002/diff/11004/cc/DEPS File cc/DEPS (right): https://codereview.chromium.org/11609002/diff/11004/cc/DEPS#newcode14 cc/DEPS:14: "+third_party/WebKit/Source/Platform/chromium/public/WebRect.h", On 2012/12/17 21:49:52, danakj wrote: > On ...
8 years ago (2012-12-17 21:52:41 UTC) #8
danakj
Thanks :)
8 years ago (2012-12-17 22:10:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11609002/11004
8 years ago (2012-12-17 22:13:21 UTC) #10
jamesr
Thanks for doing this! https://codereview.chromium.org/11609002/diff/11004/webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h File webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h (right): https://codereview.chromium.org/11609002/diff/11004/webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h#newcode22 webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h:22: ~WebToCCScrollbarThemePainterAdapter(); nit: virtual
8 years ago (2012-12-17 22:16:18 UTC) #11
danakj
https://codereview.chromium.org/11609002/diff/11004/webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h File webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h (right): https://codereview.chromium.org/11609002/diff/11004/webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h#newcode22 webkit/compositor_bindings/web_to_ccscrollbar_theme_painter_adapter.h:22: ~WebToCCScrollbarThemePainterAdapter(); On 2012/12/17 22:16:19, jamesr wrote: > nit: virtual ...
8 years ago (2012-12-17 22:17:25 UTC) #12
commit-bot: I haz the power
Failed to trigger a try job on ios_rel_device HTTP Error 400: Bad Request
8 years ago (2012-12-17 22:23:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11609002/16002
8 years ago (2012-12-17 22:25:20 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11609002/16002
8 years ago (2012-12-18 01:16:54 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11609002/16002
8 years ago (2012-12-18 02:05:05 UTC) #16
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years ago (2012-12-18 07:16:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/11609002/16003
8 years ago (2012-12-18 07:17:07 UTC) #18
commit-bot: I haz the power
8 years ago (2012-12-18 07:54:21 UTC) #19
Message was sent while issue was closed. 
Change committed as 173687

Powered by Google App Engine
This is Rietveld 408576698