Issue 1160893003: Cleanup: Introduce a RAII class for InspectorInstrumentation::willRunJavaScriptDialog and didRunJav…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1160893003: Cleanup: Introduce a RAII class for InspectorInstrumentation::willRunJavaScriptDialog and didRunJav… (Closed)

Created:
4 years, 11 months ago by tkent

Modified:
4 years, 11 months ago

Reviewers:
yosin_UTC9

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Cleanup: Introduce a RAII class for InspectorInstrumentation::willRunJavaScriptDialog and didRunJavaScriptDialog. This CL has no behavior chagnes. BUG=495378 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196273

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -15 lines)			Patch
	M	Source/core/page/ChromeClient.cpp	View		4 chunks	+23 lines, -15 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160893003/1

4 years, 11 months ago (2015-06-02 01:16:25 UTC) #5

commit-bot: I haz the power

4 years, 11 months ago (2015-06-02 01:52:21 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196273