Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1328)

Unified Diff: Source/devtools/front_end/emulation/DevicesSettingsTab.js

Issue 1160883011: [DevTools] Remove external device list update. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/emulation/EmulatedDevices.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/emulation/DevicesSettingsTab.js
diff --git a/Source/devtools/front_end/emulation/DevicesSettingsTab.js b/Source/devtools/front_end/emulation/DevicesSettingsTab.js
index 5c9de531287f9eeb77beba0422243836471fd519..f6fe57cddc6bd1b00a1e22887e120775680cba9e 100644
--- a/Source/devtools/front_end/emulation/DevicesSettingsTab.js
+++ b/Source/devtools/front_end/emulation/DevicesSettingsTab.js
@@ -24,9 +24,6 @@ WebInspector.DevicesSettingsTab = function()
var buttonsRow = this.containerElement.createChild("div", "devices-button-row");
this._addCustomButton = createTextButton(WebInspector.UIString("Add custom device..."), this._addCustomDevice.bind(this));
buttonsRow.appendChild(this._addCustomButton);
- this._updateStandardButton = createTextButton("", this._updateStandardDevices.bind(this));
- if (Runtime.experiments.isEnabled("externalDeviceList"))
- buttonsRow.appendChild(this._updateStandardButton);
this._editDevice = null;
this._editDeviceListItem = null;
@@ -35,7 +32,6 @@ WebInspector.DevicesSettingsTab = function()
this._muteUpdate = false;
WebInspector.emulatedDevicesList.addEventListener(WebInspector.EmulatedDevicesList.Events.CustomDevicesUpdated, this._devicesUpdated, this);
WebInspector.emulatedDevicesList.addEventListener(WebInspector.EmulatedDevicesList.Events.StandardDevicesUpdated, this._devicesUpdated, this);
- WebInspector.emulatedDevicesList.addEventListener(WebInspector.EmulatedDevicesList.Events.IsUpdatingChanged, this._isUpdatingChanged, this);
}
WebInspector.DevicesSettingsTab.prototype = {
@@ -43,7 +39,6 @@ WebInspector.DevicesSettingsTab.prototype = {
{
WebInspector.VBox.prototype.wasShown.call(this);
this._devicesUpdated();
- this._isUpdatingChanged();
this._stopEditing();
},
@@ -68,17 +63,6 @@ WebInspector.DevicesSettingsTab.prototype = {
this._devicesList.appendChild(this._createDeviceListItem(devices[i], false));
},
- _isUpdatingChanged: function()
- {
- if (WebInspector.emulatedDevicesList.isUpdating()) {
- this._updateStandardButton.textContent = WebInspector.UIString("Updating...");
- this._updateStandardButton.disabled = true;
- } else {
- this._updateStandardButton.textContent = WebInspector.UIString("Update devices");
- this._updateStandardButton.disabled = false;
- }
- },
-
_updateSeparatorVisibility: function()
{
this._customListSearator.classList.toggle("hidden", this._devicesList.firstChild === this._customListSearator);
@@ -317,10 +301,5 @@ WebInspector.DevicesSettingsTab.prototype = {
this._addCustomButton.focus();
},
- _updateStandardDevices: function()
- {
- WebInspector.emulatedDevicesList.update();
- },
-
__proto__: WebInspector.VBox.prototype
}
« no previous file with comments | « no previous file | Source/devtools/front_end/emulation/EmulatedDevices.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698