Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1160873006: Set up crosstest to run simple loop in Om1 on ARM (Closed)

Created:
5 years, 6 months ago by jvoung (off chromium)
Modified:
5 years, 6 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set up crosstest to run simple loop in Om1 on ARM. We can't run O2 yet because some of the advanced Phi lowering hooks aren't implemented for O2 yet. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8e32fed59522195debe86ae35c314f6bf34aed09

Patch Set 1 #

Patch Set 2 : a bit more #

Patch Set 3 : set up qemu #

Patch Set 4 : rebase part 1 #

Patch Set 5 : rebase #

Patch Set 6 : iRefactor a bit #

Patch Set 7 : thingy #

Patch Set 8 : xyz #

Total comments: 6

Patch Set 9 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -50 lines) Patch
M Makefile.standalone View 1 2 3 4 5 6 7 8 3 chunks +10 lines, -4 lines 0 comments Download
M pydir/build-runtime.py View 1 2 3 4 5 6 5 chunks +7 lines, -18 lines 0 comments Download
M pydir/crosstest.py View 1 2 3 4 5 7 chunks +29 lines, -11 lines 0 comments Download
M pydir/crosstest_generator.py View 1 2 3 4 5 6 7 8 5 chunks +45 lines, -17 lines 0 comments Download
A pydir/targets.py View 1 2 3 4 5 6 7 8 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jvoung (off chromium)
5 years, 6 months ago (2015-06-16 20:51:43 UTC) #2
Jim Stichnoth
otherwise lgtm https://codereview.chromium.org/1160873006/diff/140001/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1160873006/diff/140001/Makefile.standalone#newcode310 Makefile.standalone:310: --toolchain-root $(TOOLCHAIN_ROOT) \ line this up with ...
5 years, 6 months ago (2015-06-17 01:14:11 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/1160873006/diff/140001/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1160873006/diff/140001/Makefile.standalone#newcode310 Makefile.standalone:310: --toolchain-root $(TOOLCHAIN_ROOT) \ On 2015/06/17 01:14:10, stichnot wrote: > ...
5 years, 6 months ago (2015-06-17 17:07:53 UTC) #4
jvoung (off chromium)
5 years, 6 months ago (2015-06-17 17:16:31 UTC) #5
Message was sent while issue was closed.
Committed patchset #9 (id:160001) manually as
8e32fed59522195debe86ae35c314f6bf34aed09 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698