Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Unified Diff: runtime/vm/service.cc

Issue 1160873002: Sundry service protocol cleanups before version 1.0. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: pre commit Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 4acbb78a0e49f373618bbc3ef6cfdb7f5f01e3f7..10bd9982f1dbd9479759ff6ebb9cbeb0624d1faa 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -733,9 +733,7 @@ static bool GetStack(Isolate* isolate, JSONStream* js) {
ActivationFrame* frame = stack->FrameAt(i);
JSONObject jsobj(&jsarr);
frame->PrintToJSONObject(&jsobj, full);
- // TODO(turnidge): Implement depth differently -- differentiate
- // inlined frames.
- jsobj.AddProperty("depth", i);
+ jsobj.AddProperty("index", i);
}
}
@@ -1556,7 +1554,7 @@ static bool Evaluate(Isolate* isolate, JSONStream* js) {
static const MethodParameter* evaluate_in_frame_params[] = {
ISOLATE_PARAMETER,
- new UIntParameter("frame", true),
+ new UIntParameter("frameIndex", true),
new MethodParameter("expression", true),
NULL,
};
@@ -1564,9 +1562,9 @@ static const MethodParameter* evaluate_in_frame_params[] = {
static bool EvaluateInFrame(Isolate* isolate, JSONStream* js) {
DebuggerStackTrace* stack = isolate->debugger()->StackTrace();
- intptr_t framePos = UIntParameter::Parse(js->LookupParam("frame"));
+ intptr_t framePos = UIntParameter::Parse(js->LookupParam("frameIndex"));
if (framePos > stack->Length()) {
- PrintInvalidParamError(js, "frame");
+ PrintInvalidParamError(js, "frameIndex");
return true;
}
ActivationFrame* frame = stack->FrameAt(framePos);
« no previous file with comments | « runtime/vm/object_test.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698