Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: runtime/observatory/tests/service/get_stack_rpc_test.dart

Issue 1160873002: Sundry service protocol cleanups before version 1.0. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: pre commit Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/get_stack_rpc_test.dart
diff --git a/runtime/observatory/tests/service/get_stack_rpc_test.dart b/runtime/observatory/tests/service/get_stack_rpc_test.dart
index 152fc2acb8587f24590adf76ca06d8f85c7c6bdb..21942ea9dc7ac23170e251fc43c5cfe6e4323d78 100644
--- a/runtime/observatory/tests/service/get_stack_rpc_test.dart
+++ b/runtime/observatory/tests/service/get_stack_rpc_test.dart
@@ -58,7 +58,7 @@ var tests = [
for (var frame in stack['frames']) {
print('checking frame $frameDepth');
expect(frame.type, equals('Frame'));
- expect(frame['depth'], equals(frameDepth++));
+ expect(frame['index'], equals(frameDepth++));
expect(frame['code'].type, equals('Code'));
expect(frame['function'].type, equals('Function'));
expect(frame['script'].type, equals('Script'));
@@ -74,12 +74,11 @@ var tests = [
var msgHandlerObjectId;
for (var message in stack['messages']) {
print('checking message $messageDepth');
- expect(message.type, equals('Message'));
- expect(message['_destinationPort'], isNotNull);
- expect(message['depth'], equals(messageDepth++));
+ expect(message['index'], equals(messageDepth++));
expect(message['name'], isNotNull);
expect(message['size'], greaterThanOrEqualTo(1));
- expect(message['priority'], isNotNull);
+ expect(message['_priority'], isNotNull);
+ expect(message['_destinationPort'], isNotNull);
expect(message['handlerFunction'].type, equals('Function'));
if (message['handlerFunction'].name.contains('msgHandler')) {
msgHandlerObjectId = message['messageObjectId'];
« no previous file with comments | « runtime/observatory/tests/service/get_object_rpc_test.dart ('k') | runtime/observatory/tests/service/graph_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698