runtime/observatory/tests/service/get_object_rpc_test.dart - Issue 1160873002: Sundry service protocol cleanups before version 1.0.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/get_object_rpc_test.dart

Issue 1160873002: Sundry service protocol cleanups before version 1.0. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: pre commit Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/tests/service/dominator_tree_test.dart ('k') | runtime/observatory/tests/service/get_stack_rpc_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/tests/service/get_object_rpc_test.dart

diff --git a/runtime/observatory/tests/service/get_object_rpc_test.dart b/runtime/observatory/tests/service/get_object_rpc_test.dart

index 1d5f5070aacbe78d32e32ec277f2a9cd449d94c5..b7b511ee020ea1c1f65ea4ace24a5a9781b553e2 100644

--- a/runtime/observatory/tests/service/get_object_rpc_test.dart

+++ b/runtime/observatory/tests/service/get_object_rpc_test.dart

@@ -212,9 +212,9 @@ var tests = [

expect(result['_vmName'], startsWith('_DummyClass@'));

expect(result['abstract'], equals(false));

expect(result['const'], equals(false));

- expect(result['finalized'], equals(true));

- expect(result['implemented'], equals(false));

- expect(result['patch'], equals(false));

+ expect(result['_finalized'], equals(true));

+ expect(result['_implemented'], equals(false));

+ expect(result['_patch'], equals(false));

expect(result['library']['type'], equals('@Library'));

expect(result['script']['type'], equals('@Script'));

expect(result['super']['type'], equals('@Class'));

@@ -296,7 +296,7 @@ var tests = [

expect(result['type'], equals('Function'));

expect(result['id'], equals(id));

expect(result['name'], equals('dummyFunction'));

- expect(result['kind'], equals('RegularFunction'));

+ expect(result['_kind'], equals('RegularFunction'));

expect(result['static'], equals(false));

expect(result['const'], equals(false));

expect(result['script']['type'], equals('@Script'));

@@ -342,12 +342,12 @@ var tests = [

expect(result['type'], equals('Field'));

expect(result['id'], equals(id));

expect(result['name'], equals('dummyVar'));

- expect(result['value']['valueAsString'], equals('11'));

expect(result['const'], equals(false));

expect(result['static'], equals(true));

expect(result['final'], equals(false));

expect(result['script']['type'], equals('@Script'));

expect(result['tokenPos'], isPositive);

+ expect(result['staticValue']['valueAsString'], equals('11'));

expect(result['_guardNullable'], isNotNull);

expect(result['_guardClass'], isNotNull);

expect(result['_guardLength'], isNotNull);