Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1160863003: [turbofan] Remove the JSGraph dependency from the ControlFlowOptimizer. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove the JSGraph dependency from the ControlFlowOptimizer. The control flow optimization should work independent of the JSGraph. We used the JSGraph there because it was convinient, not because it was necessary. R=jarin@chromium.org Committed: https://crrev.com/b77df02713c1ef03844ba339035756981a481d9a Cr-Commit-Position: refs/heads/master@{#28674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -36 lines) Patch
M src/compiler/control-flow-optimizer.h View 2 chunks +8 lines, -7 lines 0 comments Download
M src/compiler/control-flow-optimizer.cc View 3 chunks +10 lines, -17 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/unittests/compiler/control-flow-optimizer-unittest.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M test/unittests/compiler/graph-unittest.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 7 months ago (2015-05-28 08:47:34 UTC) #1
Benedikt Meurer
Hey Jaro, Some minor cleanup. Please take a look. Thanks, Benedikt
5 years, 7 months ago (2015-05-28 08:48:22 UTC) #2
Jarin
lgtm
5 years, 7 months ago (2015-05-28 08:53:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160863003/1
5 years, 7 months ago (2015-05-28 08:53:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-28 09:12:57 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-28 09:13:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b77df02713c1ef03844ba339035756981a481d9a
Cr-Commit-Position: refs/heads/master@{#28674}

Powered by Google App Engine
This is Rietveld 408576698