Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1160853004: IndexedDB: continuePrimaryKey() on object store cursor should throw (Closed)

Created:
5 years, 6 months ago by jsbell
Modified:
5 years, 6 months ago
Reviewers:
cmumford
CC:
blink-reviews, jsbell+idb_chromium.org, dgrogan, cmumford
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IndexedDB: continuePrimaryKey() on object store cursor should throw Behind the --enable-experimental-web-platform-features flag, Blink supports a new continuePrimaryKey() method on IDBCursor. This is intended for use on indexes to advance a cursor to a specific (key, primaryKey) pair. It's not fully specified yet only hashed out in bugs[1] (hence, experimental). Calling the method on a cursor which has an object store rather than an index as its source hits a DCHECK. Pending a full spec for the feature, have the method throw if the cursor's source is not an index. [1] https://github.com/w3c/IndexedDB/issues/14 R=cmumford@chromium.org BUG=493443 TEST=idbcursor_continueprimarykey.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196108

Patch Set 1 #

Total comments: 2

Patch Set 2 : eschew assert_true #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
A LayoutTests/storage/indexeddb/idbcursor_continueprimarykey.html View 1 1 chunk +39 lines, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBCursor.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jsbell
cmumford@ - please take a look?
5 years, 6 months ago (2015-05-28 23:51:39 UTC) #1
cmumford
lgtm https://codereview.chromium.org/1160853004/diff/1/LayoutTests/storage/indexeddb/idbcursor_continueprimarykey.html File LayoutTests/storage/indexeddb/idbcursor_continueprimarykey.html (right): https://codereview.chromium.org/1160853004/diff/1/LayoutTests/storage/indexeddb/idbcursor_continueprimarykey.html#newcode22 LayoutTests/storage/indexeddb/idbcursor_continueprimarykey.html:22: assert_true(cursor instanceof IDBCursor, assert_class_string
5 years, 6 months ago (2015-05-29 00:32:17 UTC) #2
jsbell
https://codereview.chromium.org/1160853004/diff/1/LayoutTests/storage/indexeddb/idbcursor_continueprimarykey.html File LayoutTests/storage/indexeddb/idbcursor_continueprimarykey.html (right): https://codereview.chromium.org/1160853004/diff/1/LayoutTests/storage/indexeddb/idbcursor_continueprimarykey.html#newcode22 LayoutTests/storage/indexeddb/idbcursor_continueprimarykey.html:22: assert_true(cursor instanceof IDBCursor, On 2015/05/29 00:32:17, cmumford wrote: > ...
5 years, 6 months ago (2015-05-29 00:35:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1160853004/20001
5 years, 6 months ago (2015-05-29 00:35:29 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 01:54:06 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196108

Powered by Google App Engine
This is Rietveld 408576698