Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 1160853003: Make app.dart not spew exceptions on mouse hover (Closed)

Created:
5 years, 6 months ago by eseidel
Modified:
5 years, 6 months ago
Reviewers:
Hixie, jackson
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make app.dart not spew exceptions on mouse hover app.dart assumes touch devices, which is great. We just don't need to spam exceptions when testing inside mojo_shell with a mouse. :) R=jackson@google.com, ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d84555425fc92a023913b1d140ce19a13d792389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M sky/sdk/lib/framework/app.dart View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
jackson
lgtm
5 years, 6 months ago (2015-05-28 17:56:58 UTC) #2
eseidel
5 years, 6 months ago (2015-05-28 17:57:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d84555425fc92a023913b1d140ce19a13d792389 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698